fix(storybook): ignore nx storybook plugin from sb eslint #16725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandarini
requested review from
jaysoo,
Coly010,
FrozenPandaz,
vsavkin,
AgentEnder and
JamesHenry
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mandarini
force-pushed
the
fix/ignore-sb-react-plugin
branch
from
2565265
to
2ae0f3f
Compare
mandarini
requested review from
meeroslav,
philipjfulcher and
bcabanes
as code owners
mandarini
force-pushed
the
fix/ignore-sb-react-plugin
branch
from
2ae0f3f
to
f5f825c
Compare
Coly010
approved these changes
May 3, 2023
mandarini
force-pushed
the
fix/ignore-sb-react-plugin
branch
from
f5f825c
to
e7c952c
Compare
AgentEnder
approved these changes
May 3, 2023
jaysoo
requested changes
May 3, 2023
packages/storybook/src/migrations/update-16-1-0/eslint-ignore-react-plugin.ts
Show resolved
Hide resolved
jaysoo
approved these changes
May 3, 2023
philipjfulcher
approved these changes
May 3, 2023
meeroslav
approved these changes
May 4, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
If workspace uses
plugin:storybook/recommendedeslint plugin and@nx/react/plugins/storybookstorybook addon, then a linting error is thrown, because it cannot see that the plugin is installed. Reference: storybookjs/eslint-plugin-storybook#129Expected Behavior
If
@nx/react/plugins/storybookand workspace uses theplugin:storybook/recommendedeslint plugin, then ignore our package from theno-uninstalled-addonsrule.Also, add this rule to our
.eslintrc.json.Related Issue(s)
#16629