Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow ignore option in no-uninstalled-addons #129

Merged
merged 2 commits into from
May 3, 2023
Merged

feat: allow ignore option in no-uninstalled-addons #129

merged 2 commits into from
May 3, 2023

Conversation

mandarini
Copy link
Contributor

@mandarini mandarini commented Apr 28, 2023 •
edited
Loading

Issue: #

What Changed

Added the ignore option in the no-uninstalled-addons rule.

Checklist

Check the ones applicable to your change:

  • Ran yarn update-all
  • Tests are updated
  • Documentation is updated

Change Type

Indicate the type of change your pull request is:

  • maintenance
  • documentation
  • patch
  • minor
  • major

@mandarini mandarini requested a review from yannbf April 28, 2023 17:18
@mandarini mandarini self-assigned this Apr 28, 2023
@mandarini mandarini mentioned this pull request Apr 28, 2023
Closed
@barrymichaeldoyle
Copy link

Looking forward to this getting merged!

@barrymichaeldoyle barrymichaeldoyle mentioned this pull request May 2, 2023
Open
@mandarini
Copy link
Contributor Author

ping @yannbf :)

yannbf
yannbf approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you so much @mandarini !!

@yannbf yannbf added the patch Increment the patch version when merged label May 3, 2023
@yannbf yannbf merged commit 6399910 into storybookjs:main May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

🚀 PR was released in v0.6.12 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 3, 2023
@barrymichaeldoyle
Copy link

Thank you guys! Working smoothly in my app now 👍

@mandarini
Copy link
Contributor Author

Thank youuuuu!!!! :D

@mandarini mandarini mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@mandarini mandarini

Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mandarini @barrymichaeldoyle @yannbf