Improve FSTree behaviour for partially written objects #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgenii Stratonikov <[email protected]>
Signed-off-by: Evgenii Stratonikov <[email protected]>
Currently the only way to tell whether `evacuate/set-mode` is finished is to set a very big timeout and _hope_ that the operation will finish. In this commit we add INFO logs for such operations which should simplify the life of an administrator. Signed-off-by: Evgenii Stratonikov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## support/v0.35 #2208 +/- ##
=================================================
+ Coverage 30.88% 30.90% +0.02%
=================================================
Files 383 383
Lines 28354 28364 +10
=================================================
+ Hits 8757 8766 +9
- Misses 18851 18852 +1
Partials 746 746
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acid-ant
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, log time-consuming operations to help administrator observe system behaviour until we have a proper async operations support in
controlservice.