Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up temporary files in blobstor #2291

Closed
roman-khimov opened this issue Mar 21, 2023 · 2 comments · Fixed by #2967
Closed

Clean up temporary files in blobstor #2291

roman-khimov opened this issue Mar 21, 2023 · 2 comments · Fixed by #2967
Labels
bug Something isn't working good first issue Good for newcomers I4 No visible changes neofs-storage Storage node application issues S3 Minimally significant U4 Nothing urgent
Milestone
v0.44.0

Comments

@roman-khimov
Copy link
Member

Expected Behavior

Blobstor only containing stored files.

Current Behavior

After #2208 we can have some f# garbage.

Possible Solution

Clean it up during startup or as an additional maintenance command.
@roman-khimov roman-khimov added the neofs-storage Storage node application issues label Mar 21, 2023
@roman-khimov roman-khimov added this to the v0.37.0 milestone Mar 28, 2023
@roman-khimov roman-khimov modified the milestones: v0.37.0, v0.38.0 Jun 5, 2023
@roman-khimov roman-khimov modified the milestones: v0.38.0, v0.39.0 Aug 4, 2023
@roman-khimov roman-khimov removed this from the v0.39.0 milestone Sep 25, 2023
@roman-khimov
Copy link
Member Author

O_TMPFILE solved it for Linux, we don't officially support anything else now.

@roman-khimov roman-khimov added bug Something isn't working U4 Nothing urgent S3 Minimally significant I4 No visible changes labels Dec 21, 2023
@roman-khimov
Copy link
Member Author

Still, the code is there and can be triggered in some scenarios, so a lens extension still makes sense.

@roman-khimov roman-khimov added the good first issue Good for newcomers label Sep 25, 2024
End-rey added a commit that referenced this issue Oct 9, 2024
@End-rey
fstree: clean up temporary files
8f8345b 
Add method to remove temporary files from `genericWriter.writeData` and call it
in `FSTree.Init`.

Closes #2291.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Oct 9, 2024
@End-rey
neofs-lens: add fstree cleanup-tmp command
63a593a 
Add command to cleaning up temporary files in FSTree by path.

Ref #2291.

Signed-off-by: Andrey Butusov <[email protected]>
@End-rey End-rey mentioned this issue Oct 9, 2024
Merged
End-rey added a commit that referenced this issue Oct 9, 2024
@End-rey
fstree: clean up temporary files
f9930c4 
Add method to remove temporary files from `genericWriter.writeData` and call it
in `FSTree.Init`.

Closes #2291.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Oct 9, 2024
@End-rey
neofs-lens: add fstree cleanup-tmp command
f156fb4 
Add command to cleaning up temporary files in FSTree by path.

Ref #2291.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Oct 9, 2024
@End-rey
neofs-lens: add fstree cleanup-tmp command
86983e2 
Add method to remove temporary files from `genericWriter.writeData` and add
`lens` command to cleaning up temporary files in FSTree by path.

Closes #2291.

Signed-off-by: Andrey Butusov <[email protected]>
End-rey added a commit that referenced this issue Oct 11, 2024
@End-rey
neofs-lens: add fstree cleanup-tmp command
db88a84 
Add method to remove temporary files from `genericWriter.writeData` and add
`lens` command to cleaning up temporary files in FSTree by path.

Closes #2291.

Signed-off-by: Andrey Butusov <[email protected]>
@roman-khimov roman-khimov added this to the v0.44.0 milestone Oct 14, 2024
End-rey added a commit that referenced this issue Oct 16, 2024
@End-rey
neofs-lens: add fstree cleanup-tmp command
1487dee 
Add method to remove temporary files from `genericWriter.writeData` and add
`lens` command to cleaning up temporary files in FSTree by path.

Closes #2291.

Signed-off-by: Andrey Butusov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers I4 No visible changes neofs-storage Storage node application issues S3 Minimally significant U4 Nothing urgent
Projects
None yet
Milestone
v0.44.0
Development

Successfully merging a pull request may close this issue.

fstree : clean up temporary files nspcc-dev/neofs-node
1 participant
@roman-khimov