Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fstree : clean up temporary files #2967

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

End-rey
Copy link
Contributor

@End-rey End-rey commented Oct 9, 2024

Add lens command and also clean up due startup.

Closes #2291.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@e254f00). Learn more about missing BASE report.
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-lens/internal/fstree/root.go 0.00% 16 Missing ⚠️
pkg/local_object_storage/blobstor/fstree/fstree.go 0.00% 15 Missing ⚠️
cmd/neofs-lens/internal/fstree/cleanup.go 0.00% 9 Missing ⚠️
cmd/neofs-lens/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2967   +/-   ##
=========================================
  Coverage          ?   23.47%           
=========================================
  Files             ?      780           
  Lines             ?    46655           
  Branches          ?        0           
=========================================
  Hits              ?    10951           
  Misses            ?    34834           
  Partials          ?      870           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@End-rey End-rey force-pushed the 2291-clean-up-temporary-files-in-blobstor branch from 63a593a to f156fb4 Compare October 9, 2024 15:00
@End-rey End-rey force-pushed the 2291-clean-up-temporary-files-in-blobstor branch from f156fb4 to 86983e2 Compare October 9, 2024 15:10
cmd/neofs-lens/internal/fstree/root.go Outdated Show resolved Hide resolved
pkg/local_object_storage/blobstor/fstree/fstree.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/fstree/root.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/fstree/cleanup.go Outdated Show resolved Hide resolved
Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont mind additional command but i would go as an internal cleaning routine; as usual do not understand why "lens" is changing smth

pkg/local_object_storage/blobstor/fstree/fstree.go Outdated Show resolved Hide resolved
pkg/local_object_storage/blobstor/fstree/fstree.go Outdated Show resolved Hide resolved
@End-rey End-rey force-pushed the 2291-clean-up-temporary-files-in-blobstor branch from 86983e2 to db88a84 Compare October 11, 2024 11:59
cmd/neofs-lens/internal/fstree/cleanup.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/fstree/root.go Outdated Show resolved Hide resolved
cmd/neofs-lens/internal/fstree/root.go Outdated Show resolved Hide resolved
Add method to remove temporary files from `genericWriter.writeData` and add
`lens` command to cleaning up temporary files in FSTree by path.

Closes #2291.

Signed-off-by: Andrey Butusov <[email protected]>
@End-rey End-rey force-pushed the 2291-clean-up-temporary-files-in-blobstor branch from db88a84 to 1487dee Compare October 16, 2024 10:05
@roman-khimov roman-khimov merged commit c4bdae1 into master Oct 16, 2024
19 of 21 checks passed
@roman-khimov roman-khimov deleted the 2291-clean-up-temporary-files-in-blobstor branch October 16, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up temporary files in blobstor
3 participants