Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules in Special Term do not show up in Today page #3830

Open
ravern opened this issue Sep 30, 2024 · 2 comments
Open

Modules in Special Term do not show up in Today page #3830

ravern opened this issue Sep 30, 2024 · 2 comments
Labels

Comments

@ravern
Copy link
Member

ravern commented Sep 30, 2024

Describe the bug

After adding modules to my Special Term timetable, they do not show up in the Today page.

To Reproduce

Steps to reproduce the behavior:

  1. Add some modules with timeslots to your Special Term timetable (I'm using this one https://nusmods.com/courses/GES1002T/global-economic-dimensions-of-singapore)
  2. Visit https://nusmods.com/today?date=2025-06-06 with the date query parameter to simulate the date of NUSMods
  3. Module does not appear in the today page

Expected behavior

The module appears on the today page, just like how regular semester modules do.

Screenshots

image

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Arc
  • Version 1.61.2

Additional context

Seems tangential to #3757.

@ravern
Copy link
Member Author

ravern commented Sep 30, 2024

for (let current = parseISO(weekRange.start); current <= end; current = addDays(current, 7)) {
if (isEqual(current, date)) return true;
}

This should be isEqual(current, startOfDay(date))

@xinyuwang-nus
Copy link
Contributor

for (let current = parseISO(weekRange.start); current <= end; current = addDays(current, 7)) {
if (isEqual(current, date)) return true;
}

This should be isEqual(current, startOfDay(date))

fixed in a43106a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants