-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Modules in Special Term do not show up in Today page #3814
base: master
Are you sure you want to change the base?
Fix Modules in Special Term do not show up in Today page #3814
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@xinyuwang-nus is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
This reverts commit c1a8574.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3814 +/- ##
==========================================
+ Coverage 53.87% 54.63% +0.75%
==========================================
Files 274 274
Lines 6032 6058 +26
Branches 1449 1448 -1
==========================================
+ Hits 3250 3310 +60
+ Misses 2782 2748 -34 ☔ View full report in Codecov by Sentry. |
b17dcae
to
a143a4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in reviewing this!
I've added #3757 (comment) after doing a deep dive into the issue.
I'm good to merge this once the linting errors are fixed, since this solves the issue for now. You can find the linting errors by clicking the "Details" link in the failing "build_and_test" workflow, then navigating to the "Tests" tab.
Here's a direct link to that page: https://app.circleci.com/pipelines/github/nusmodifications/nusmods/14863/workflows/fc3ce863-17e5-49a2-84e9-2d99e12ab411/jobs/89894/tests
80eed86
to
8471486
Compare
Context
#3757
#3830
Implementation
Other Information