-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail on Nuxt 3 RC9 #91
Comments
Fails the call to const { result, search } = useAlgoliaSearch('XXXXXX') |
Hey @agracia-foticos I am currently on holidays without access to the computer so I wont be able to release a new version with a fix. I will do that later in september when I will be back. Also, could you please paste the error here with more descriptive info? |
@Baroshem there was a breaking change introduced in nuxt rc 9, check out nuxt/framework#7116 |
This the error from vite :
|
i deploy to Vercel and this is what i get: i assume it's because of this:
|
Guys, thanks for explaining the issue. It seems that the nuxt core team released a breaking change in the nuxt kit. The fix should be relatively simple (replacing the hook) but I wont be able to release a fix version with it as I am currently on holidays. I will be back end of september and then I will release the new version to fix your issues. |
Does anyone have a quick fix for this in the meantime? |
@monkemedia Here is my patch. You can use patch-package and add the code below to diff --git a/node_modules/@nuxtjs/algolia/dist/module.json b/node_modules/@nuxtjs/algolia/dist/module.json
index 506aa8c..7b327a0 100644
--- a/node_modules/@nuxtjs/algolia/dist/module.json
+++ b/node_modules/@nuxtjs/algolia/dist/module.json
@@ -2,7 +2,7 @@
"name": "@nuxtjs/algolia",
"configKey": "algolia",
"compatibility": {
- "nuxt": "^3.0.0 || ^2.16.0",
+ "nuxt": "^3.0.0-rc.9 || ^2.16.0",
"bridge": true
},
"version": "1.1.1"
diff --git a/node_modules/@nuxtjs/algolia/dist/module.mjs b/node_modules/@nuxtjs/algolia/dist/module.mjs
index e37b246..13aba7d 100644
--- a/node_modules/@nuxtjs/algolia/dist/module.mjs
+++ b/node_modules/@nuxtjs/algolia/dist/module.mjs
@@ -90,7 +90,7 @@ const module = defineNuxtModule({
name: "@nuxtjs/algolia",
configKey: "algolia",
compatibility: {
- nuxt: "^3.0.0 || ^2.16.0",
+ nuxt: "^3.0.0-rc.9 || ^2.16.0",
bridge: true
}
}, |
@lukaszflorczak Once I make these changes, do I do anything else? I just re-ran |
|
@lukaszflorczak thank you for the instructions. I have never used patch package before. Seem to have done everything correctly and the patch has been installed, however, I am still getting the same error |
Fixed it by following this #84 |
Guys, the new version has been released. You can verify now if it works correctly. I have tested it in several nuxt projects and it is working correctly :) |
In my project, everything works fine (tested on |
works with rc9 to rc11. |
Closing the issue then. Thanks for the input guys! |
Version
@nuxtjs/algolia: 1.1.0
nuxt: 3.0.0-rc.9
Reproduction Link
We have updated Nuxt to version 3 RC 9 and it has thrown us an error. Please update module to work with RC 9
The text was updated successfully, but these errors were encountered: