Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module): rc9 compatibility issues #92

Merged
merged 1 commit into from
Sep 21, 2022
Merged

fix(module): rc9 compatibility issues #92

merged 1 commit into from
Sep 21, 2022

Conversation

Intevel
Copy link
Contributor

@Intevel Intevel commented Sep 8, 2022

Will fix #90 and #91
@Baroshem

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for nuxt-algolia-module canceled.

Name Link
🔨 Latest commit 97c4a10
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-algolia-module/deploys/6319e16baf8aaa0008eef813

@Lexpeartha
Copy link

Not a module author, but it might be helpful to add a message in docs that says rc 9 of nuxt is required version in order to function?

@lukaszflorczak
Copy link

It looks that addAutoImportDir() is also (soft) depreciated and changed to addImportsDir()

Source: nuxt/framework#7158

@Intevel
Copy link
Contributor Author

Intevel commented Sep 13, 2022

The autoImports hook was deprecated, or am I wrong?

@lukaszflorczak
Copy link

They renamed utils:

Updated kit utils:
Soft deprecated (type only) addAutoImport to addImports and addAutoImportDir to addImportsDir for consistency

@Intevel
Copy link
Contributor Author

Intevel commented Sep 13, 2022

Ah okay thank you, I will update this.

@Baroshem
Copy link
Collaborator

Hey folks,

thanks for this PR. I am back from holidays and will merge this PR and release a new version so that you could use it without errors tomorrow.

Thanks for the patience.

@Baroshem Baroshem merged commit 0abc3be into nuxt-modules:main Sep 21, 2022
@Baroshem
Copy link
Collaborator

Not a module author, but it might be helpful to add a message in docs that says rc 9 of nuxt is required version in order to function?

@Lexpeartha I think that the support for the most recent RC version is expected when using the module. Right now, the module does not work with the most current version of the Nuxt so all new Nuxt project have the Algolia module disabled. I dont think this info needs to be added to the docs. As a software user, I expect it to work with the most modern and stable update :)

@Baroshem
Copy link
Collaborator

Guys, the new version has been released. You can verify now if it works correctly. I have tested it in several nuxt projects and it is working correctly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module @nuxtjs/algolia is disabled due to incompatibility issues
4 participants