Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #2015 Update definitions for bladder urothelial cell types #2016

Merged
5 commits merged into from
Jun 9, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/ontology/cl-edit.owl
Original file line number Diff line number Diff line change
Expand Up @@ -26265,8 +26265,7 @@ AnnotationAssertion(Annotation(oboInOwl:hasDbXref "GOC:tfm") obo:IAO_0000115 obo
AnnotationAssertion(oboInOwl:hasDbXref obo:CL_1000442 "FMA:70598")
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "FMA:70598") oboInOwl:hasExactSynonym obo:CL_1000442 "epithelial cell of vesical trigone")
AnnotationAssertion(rdfs:label obo:CL_1000442 "urothelial cell of trigone of urinary bladder")
EquivalentClasses(obo:CL_1000442 ObjectIntersectionOf(obo:CL_0000731 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0001257)))
SubClassOf(Annotation(oboInOwl:is_inferred "true") obo:CL_1000442 obo:CL_0000731)
EquivalentClasses(obo:CL_1000442 ObjectIntersectionOf(obo:CL_0000731 ObjectSomeValuesFrom(obo:BFO_0000050 ObjectIntersectionOf(obo:UBERON_0000365 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0001257)))))

# Class: obo:CL_1000443 (ciliary muscle cell)

Expand Down Expand Up @@ -27607,12 +27606,10 @@ SubClassOf(obo:CL_1001320 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_000005

# Class: obo:CL_1001428 (bladder urothelial cell)

AnnotationAssertion(Annotation(oboInOwl:hasDbXref "doi:10.1038/s41385-022-00565-0") obo:IAO_0000115 obo:CL_1001428 "A urothelial cell that is part of the urothelium of the urinary bladder.")
AnnotationAssertion(oboInOwl:hasDbXref obo:CL_1001428 "KUPO:0001121")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why rdfs:comment? This is a definition, should be IAO:0000115.

Also urothellial -> urothelial.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting both.
I've noticed Protégé will sometimes default to rdfs:comment. Thank you for catching.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And coming back to an earlier discussion: In this case, should it be “An urothelial cell” or “A urothelial cell”? (Genuine question; I’d be inclined to say “an”, but I’ll happily yield to native English speakers on that point.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this instance it should be "A" since "urothelial" starts with a consonant sound, like "urine" or "university".

AnnotationAssertion(rdfs:label obo:CL_1001428 "bladder urothelial cell")
EquivalentClasses(obo:CL_1001428 ObjectIntersectionOf(obo:CL_0000731 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0004645)))
SubClassOf(Annotation(oboInOwl:is_inferred "true") obo:CL_1001428 obo:CL_0000731)
SubClassOf(Annotation(oboInOwl:is_inferred "true") obo:CL_1001428 obo:CL_1001319)
SubClassOf(obo:CL_1001428 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0004645))

# Class: obo:CL_1001430 (urethra urothelial cell)

Expand Down