Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #2015 Update definitions for bladder urothelial cell types #2016

Merged
5 commits merged into from
Jun 9, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 9, 2023

Addresses #2015 Update definitions for bladder urothelial cell types

@ghost ghost self-assigned this Jun 9, 2023
@ghost
Copy link
Author

ghost commented Jun 9, 2023

#gogoeditdiff

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-06-09/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-06-09/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

bladder urothelial cell http://purl.obolibrary.org/obo/CL_1001428

Removed

Added

urothelial cell of trigone of urinary bladder http://purl.obolibrary.org/obo/CL_1000442

Removed

Added

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

bladder urothelial cell http://purl.obolibrary.org/obo/CL_1001428

Removed

Added

urothelial cell of trigone of urinary bladder http://purl.obolibrary.org/obo/CL_1000442

Removed

Added

fix dbxref
@ghost ghost linked an issue Jun 9, 2023 that may be closed by this pull request
4 tasks
@dosumis
Copy link
Contributor

dosumis commented Jun 9, 2023

Please see comments on ticket.

@ghost
Copy link
Author

ghost commented Jun 9, 2023

#gogoeditdiff

@ghost ghost changed the title Addresses #2105 Update definitions for 'bladder urothelial cell' Addresses #2105 Update definitions for bladder urothelial cell types Jun 9, 2023
@ghost ghost requested review from dosumis and gouttegd June 9, 2023 10:39
@ghost ghost changed the title Addresses #2105 Update definitions for bladder urothelial cell types Addresses #2015 Update definitions for bladder urothelial cell types Jun 9, 2023
Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine for CL:1000442.

Incorrect annotation property (rdfs:comment instead of IAO:0000115) and typo for CL:1001428.

@@ -27608,11 +27607,9 @@ SubClassOf(obo:CL_1001320 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_000005
# Class: obo:CL_1001428 (bladder urothelial cell)

AnnotationAssertion(oboInOwl:hasDbXref obo:CL_1001428 "KUPO:0001121")
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "doi:10.1038/s41385-022-00565-0") rdfs:comment obo:CL_1001428 "A urothellial cell that is part of the urothelium of the urinary bladder.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why rdfs:comment? This is a definition, should be IAO:0000115.

Also urothellial -> urothelial.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting both.
I've noticed Protégé will sometimes default to rdfs:comment. Thank you for catching.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And coming back to an earlier discussion: In this case, should it be “An urothelial cell” or “A urothelial cell”? (Genuine question; I’d be inclined to say “an”, but I’ll happily yield to native English speakers on that point.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this instance it should be "A" since "urothelial" starts with a consonant sound, like "urine" or "university".

@ghost ghost requested a review from gouttegd June 9, 2023 13:15
@ghost ghost merged commit 0e87da6 into master Jun 9, 2023
@ghost ghost deleted the 2015-edit-bladder-urothelial-cell branch June 9, 2023 13:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logical def] Update bladder urothelial cell classes
2 participants