-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses #2015 Update definitions for bladder urothelial cell types #2016
Conversation
#gogoeditdiff |
Here's a diff of how these changes impact the classified ontology (on -simple file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsbladder urothelial cell
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsbladder urothelial cell
|
fix dbxref
Please see comments on ticket. |
#gogoeditdiff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine for CL:1000442.
Incorrect annotation property (rdfs:comment
instead of IAO:0000115
) and typo for CL:1001428.
@@ -27608,11 +27607,9 @@ SubClassOf(obo:CL_1001320 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_000005 | |||
# Class: obo:CL_1001428 (bladder urothelial cell) | |||
|
|||
AnnotationAssertion(oboInOwl:hasDbXref obo:CL_1001428 "KUPO:0001121") | |||
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "doi:10.1038/s41385-022-00565-0") rdfs:comment obo:CL_1001428 "A urothellial cell that is part of the urothelium of the urinary bladder.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why rdfs:comment
? This is a definition, should be IAO:0000115
.
Also urothellial
-> urothelial
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for spotting both.
I've noticed Protégé will sometimes default to rdfs:comment. Thank you for catching.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And coming back to an earlier discussion: In this case, should it be “An urothelial cell” or “A urothelial cell”? (Genuine question; I’d be inclined to say “an”, but I’ll happily yield to native English speakers on that point.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this instance it should be "A" since "urothelial" starts with a consonant sound, like "urine" or "university".
Addresses #2015 Update definitions for bladder urothelial cell types