Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #2103 Additional edits to 'pain receptor cell' #2105

Merged
1 commit merged into from
Aug 17, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 17, 2023

Follow-up edits to issue #2103 / PR #2104:

  • added anyURI datatype to URL references
  • removed MeSH Tree Number references

remove MeSH Tree Number references
@ghost ghost self-assigned this Aug 17, 2023
@ghost ghost requested a review from shawntanzk August 17, 2023 08:08
@ghost ghost linked an issue Aug 17, 2023 that may be closed by this pull request
2 tasks
@@ -5333,13 +5333,10 @@ SubClassOf(obo:CL_0000197 obo:CL_0000003)
# Class: obo:CL_0000198 (pain receptor cell)

AnnotationAssertion(Annotation(oboInOwl:hasDbXref "MESH:D009619") obo:IAO_0000115 obo:CL_0000198 "The peripheral receptor for pain. Includes receptors which are sensitive to painful mechanical stimuli, extreme heat or cold, and chemical stimuli. All mammalian nociceptors are free nerve endings.")
AnnotationAssertion(Annotation(rdfs:seeAlso "https://meshb.nlm.nih.gov/record/ui?ui=D009619") oboInOwl:hasExactSynonym obo:CL_0000198 "nociceptor")
AnnotationAssertion(Annotation(rdfs:seeAlso "https://www.thefreedictionary.com/nocireceptor") oboInOwl:hasExactSynonym obo:CL_0000198 "nocireceptor")
AnnotationAssertion(Annotation(rdfs:seeAlso "https://meshb.nlm.nih.gov/record/ui?ui=D009619"^^xsd:anyURI) oboInOwl:hasExactSynonym obo:CL_0000198 "nociceptor")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be dbxref then? brief look at previous PR https:/obophenotype/cell-ontology/pull/1558/files seems to suggest so

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt review. Logic detailed below.

Context: Current editor guidelines, under section titled "Technical details of adding a cross-reference using Protégé"

MESH:D009619 directs to https://id.nlm.nih.gov/mesh/D009619.html.
"MESH:D009619" would be added using database_cross_reference.

In this case, the link "https://meshb.nlm.nih.gov/record/ui?ui=D009619" is used since the page at that location more clearly justifies the synonym.

Screenshot 2023-08-17 at 10 10 45

Per current editor guidelines, URLs should be used sparingly, but when used are added using 'see also' with datatype xsd:anyURI.

@ghost ghost merged commit f949689 into master Aug 17, 2023
1 check passed
@ghost ghost deleted the 2103-Edit-pain_receptor_cell branch August 17, 2023 10:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nociceptor appears in both uberon and CL as different terms (CL edits)
1 participant