Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for generic front logout channel #334

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

StarAurryon
Copy link

@StarAurryon StarAurryon commented Sep 7, 2021

All Submissions:

Changes proposed in this Pull Request:

Implementing standard OpenID front logout channel as per https://openid.net/specs/openid-connect-frontchannel-1_0.html.

Closes #336 .

How to test the changes in this Pull Request:

  1. Fill the revoke endpoint in the settings of the plugin;
  2. Do a GET on /wp-admin/admin-ajax.php?action=openid-connect-logout&sid=TOKEN_SID&iss=TOKEN_ISS with the browser of a connected user;
  3. The user should be disconnected.

Changelog entry

  • Adding revoke OpenID endpoint in the settings;
  • Adding openid-connect-logout endpoint to perform the front logout (iframe rendered by the client).

Copy link
Collaborator

@timnolte timnolte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StarAurryon this PR includes files that shouldn't be in the repository. Also this branch is not up-to-date with all of the latest changes in dev. Please update your branch and remove the invalid files.

@timnolte
Copy link
Collaborator

timnolte commented Sep 8, 2021

@StarAurryon also, this PR doesn't pass code quality checks so that also needs to be addressed. Your PR doesn't reference any open issues/feature requests if there are any open issues that pertain to this change they should be referenced in your PR. Thanks!

@StarAurryon
Copy link
Author

My apologies. I was not able to set up the proper testing framework at first (requiring composer 1) and I had to dig a bit further to find what was missing.

Hope this is better now.

@timnolte timnolte added enhancement Issues & PRs related to new features. status: needs review PR that needs review. labels Mar 23, 2022
@timnolte timnolte deleted the branch oidc-wp:develop December 23, 2023 00:56
@timnolte timnolte closed this Dec 23, 2023
@timnolte timnolte reopened this Dec 23, 2023
@timnolte timnolte changed the base branch from dev to develop December 23, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues & PRs related to new features. status: needs review PR that needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for front logout channel
2 participants