Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBF: add basic FLIM support #3141

Merged
merged 2 commits into from
Jun 27, 2018
Merged

OBF: add basic FLIM support #3141

merged 2 commits into from
Jun 27, 2018

Conversation

melissalinkert
Copy link
Member

See https://trac.openmicroscopy.org/ome/ticket/13196.

To test, use the file from QA 17111. Without this PR, showinf -nopix should report 43 series, each with SizeX and SizeZ similar but SizeY noticeably different. With this PR, the same command should show 43 series, each of which has SizeX equivalent to SizeY. This should be consistent with the ticket description. It is probably also worth checking the 256x256 series in ImageJ to verify that the images look plausible for FLIM data.

Builds should continue to pass without any configuration changes for existing datasets. This might be safe for a patch release, but is definitely low priority either way.

@dgault dgault added this to the 5.9.0 milestone Jun 12, 2018
@dgault
Copy link
Member

dgault commented Jun 27, 2018

Builds and tests have been green with this PR included.

Tested with the file in QA-17111. Without this PR the file shows 43 series, many of which have odd heights such 256x1. The series do not appear to display correctly either.

With this PR included the series have equal X and Y values and opening each series shows that the images are displaying properly.

@dgault dgault merged commit 65321bf into ome:develop Jun 27, 2018
@melissalinkert melissalinkert deleted the obf-fixes branch July 11, 2018 15:48
@dgault
Copy link
Member

dgault commented Nov 11, 2019

Hi @bjoernthiel, thank you for helping to identify the issue. Using the sample file you attached I was able to reproduce the problem and it appears the problem is due to the dimensions being incorrectly set at https:/ome/bioformats/pull/3141/files#diff-5720da964f9ddb1ef5d8d17f099f4d2fR457

This should be something which we can fix for the next patch release. In the sample file provided the problem occurred when the dimensions for the second image are read as [259, 40, 250, 1, 1] and the labels as [ExpControl X, ExpControl Z, ExpControl Y, None, None]. As such the code attempted to set the dimensions as below with Z and Y inverted:
X: 259
Z: 40
Y: 250

Can you confirm that the labels being parsed are correct and in the right order?

@bjoernthiel
Copy link
Contributor

Yes, the labels are [ExpControl X, ExpControl Z, ExpControl Y, ...] and the dimensions are [259, 40, 250, ...].

@bjoernthiel
Copy link
Contributor

@dgault @melissalinkert
Is there something else I can help with?

@dgault
Copy link
Member

dgault commented Nov 25, 2019

@bjoernthiel, I will try and get a PR opened in the next few days with the aim of having a fix in place for the next patch release 6.3.1

The sample file provided should be sufficient for testing purposes but if there are any additional files which can be used for testing that would also be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants