OBF: Incorrect dimensions fix #3478
Conversation
|
The sample file for testing can be found at |
There was a problem hiding this comment.
Without this PR, the Bio-Formats command line utility detects the sample file as 2 images of dimensions 250x250x1x1x1 and 259x250x250x1x1 respectively. openBytes fails to open the second image with a Corrupted zlib compression exception which reflects the incorrect dimensions. Importing the image into an OMERO server for comparison fails during the PixelData step due to the openBytes error
With this PR included, the images are detected with dimensions 250x250x1x1x1 and 259x49x250x1x1 and all planes read as expected.
The fix is good for inclusion in the upcoming patch release. As noted above, the sample file should also be configured for inclusion in the daily QA repository tests to prevent future regressions.
@bjoernthiel is it okay to add the sample file to our public images under the CC-BY license? Or would you rather keep it private?
|
Merging for release as part of 6.3.1 |
|
@sbesson keep the sample image private please. |
This is a follow up to address the issues which have been reported in #3141
In this scenario the dimensions are only updated from the label if they have not already been set.
The provided sample file can be used for testing. Without this PR the second series should throw an exception. With this PR it should read and display without error.
I will open a config PR with the new sample file.