Change verifyPayersBalanceForTransactionExecution #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contracts/FlowFees.cdc
Outdated
Comment on lines
121
to
123
| let tokenVault = payerAcct.borrow<&FlowToken.Vault>(from: /storage/flowTokenVault) | ||
| ?? panic("Unable to borrow reference to the default token vault") | ||
|
|
There was a problem hiding this comment.
Shouldn't this be deleted since you do it below?
There was a problem hiding this comment.
good catch! Forgot to delete it after changing it.
janezpodhostnik
force-pushed
the
janez/change-verifyPayersBalanceForTransactionExecution
branch
from
f6dcf6c
to
fb2d0f0
Compare
|
Any Idea why this would fail the js tests? |
|
@sisyphusSmiling @alilloig Can y'all look at the CI here and try to help figure out why the JS tests are failing? |
|
@joshuahannan at a quick glance, I believe it's related to the updates to Flow CLI which make versions beyond 0.42.0 incompatible with flow-js-testing. I was able to fix this earlier today in this PR to flow-ft, and will take a closer look in the morning |
joshuahannan
approved these changes
Dec 16, 2022
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Jan 4, 2023
3733: Upgrade core contracts r=janezpodhostnik a=janezpodhostnik ... to include: onflow/flow-core-contracts#331 Co-authored-by: Janez Podhostnik <[email protected]>
joshuahannan
deleted the
janez/change-verifyPayersBalanceForTransactionExecution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimumRequiredBalanceshould actually be equal toreservedBalance.The
maxTransactionFeewas removed fromminimumRequiredBalanceas it is generally much smaller then thereservedBalanceand only covers some edge cases, so its simpler to just not include it (as pointed out by @bluesign here).