Upgrade core contracts #3733
Merged
Upgrade core contracts #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3733 +/- ##
==========================================
- Coverage 55.50% 55.37% -0.13%
==========================================
Files 765 769 +4
Lines 69798 70257 +459
==========================================
+ Hits 38739 38906 +167
- Misses 27881 28163 +282
- Partials 3178 3188 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit b2dce40 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
pattyshack
approved these changes
Dec 19, 2022
m4ksio
approved these changes
Dec 23, 2022
janezpodhostnik
force-pushed
the
janez/upgrade-core-contracts-again
branch
from
2a673aa
to
ae704df
Compare
janezpodhostnik
requested review from
gomisha and
yhassanzadeh13
as code owners
|
I had to rollback some test changes made in #3473 due to the payer balance check change in onflow/flow-core-contracts#331 |
pattyshack
approved these changes
Jan 3, 2023
gomisha
reviewed
Jan 3, 2023
gomisha
approved these changes
Jan 3, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Feb 3, 2023
3770: Upgrade core contracts - port to v0.29 r=janezpodhostnik a=janezpodhostnik Port of #3733 to v0.29 This doesn't actually change anything for canary testnet or mainnet since the core contracts are already (or will be for mainnet) at the correct version. This does affect transient networks (most notably the emulator), due to a slightly different version of the contracts being deployed. Co-authored-by: Janez Podhostnik <[email protected]>
bors bot
added a commit
that referenced
this pull request
Feb 3, 2023
3770: Upgrade core contracts - port to v0.29 r=janezpodhostnik a=janezpodhostnik Port of #3733 to v0.29 This doesn't actually change anything for canary testnet or mainnet since the core contracts are already (or will be for mainnet) at the correct version. This does affect transient networks (most notably the emulator), due to a slightly different version of the contracts being deployed. Co-authored-by: Janez Podhostnik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to include: onflow/flow-core-contracts#331