Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metricstransformprocessor] convert resource attributes to metric labels #1297

Closed
hossain-rayhan opened this issue Oct 19, 2020 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@hossain-rayhan
Copy link
Contributor

hossain-rayhan commented Oct 19, 2020

Is your feature request related to a problem? Please describe.
When we gather metrics in the receiver, we set some resource attributes as well as metric labels based on the data definition. While sending these metrics to destination (AWS CloudWatch), some of the resource attributes should be converted to metric dimensions. However, it's not common that all exporters will read resource attributes to set them as metric dimensions. So, we need some kind of mechanism in the processor to convert the resource attributes to metric labels and I feel metricstransform processor is a good candidate for it.

Describe the solution you'd like
For our use case, one boolean settings in the processor is good enough. Like convert_resource_attributes_to_labels=true will convert all the resource attributes to metric labels and apply them to all metrics. However, for giving more custom settings like select specific metrics and specific resource attributes, we can consider extending the add_label operation.

Describe alternatives you've considered
In our receiver, we can set all the resource attributes as metric labels also. Here is a PR [#1284] open but the reviewer raised concerns.

@tigrannajaryan
Copy link
Member

Related to or a duplicate of open-telemetry/opentelemetry-collector#1892

@hossain-rayhan
Copy link
Contributor Author

This feature is implemented in the exporterhelper of core collector. Check the PR 2060.

@andrewhsu andrewhsu added the enhancement New feature or request label Jan 6, 2021
dyladan referenced this issue in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
* Allow partial retries in queued retry processor

Signed-off-by: Pavol Loffay <[email protected]>

* Rename consumererror file

Signed-off-by: Pavol Loffay <[email protected]>

* Fix data race

Signed-off-by: Pavol Loffay <[email protected]>
ljmsc referenced this issue in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
codeboten pushed a commit that referenced this issue Nov 23, 2022
* Update package metadata

* Update instrumentation/opentelemetry-instrumentation-starlette/pyproject.toml

Co-authored-by: Srikanth Chekuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants