awsecscontainermetrics: Set task/container metadata as metric labels #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rayhan Hossain <[email protected]>
|
Copied from other PR - @hossain-rayhan Unfortunately resource is resource - I think it's precisely the exporter layer that should deal with handling resource attributes correctly and not correct for the receiver to fill these in as labels. Apps send resource, so if the exporter isn't handling it correctly, then app metrics are already broken anyways. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Earlier we decided to add task and container metadata as resource attributes. However, CloudWatch
awsemfexporter reads dimensions only from metric labels. As this exporter is a major target forawsecscontainermetricsreceiver, we need to add these metadata as metric labels. I discussed this in our OTel Metric SIG meeting. We also discussed internally and agreed to add them as metric labels as well.Link to tracking Issue:
#1281
Testing:
Unit test added.