Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geneva-exporter] add traceflag override method to fluentd exporter #385

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

ThomsonTan
Copy link
Contributor

@ThomsonTan ThomsonTan commented Feb 17, 2024

Upgrade opentelemtry-proto to 1.1.0 in main repo added TraceFlags to class Recordable. The fluentd exporter has to override it or it will be an abstract class and cannot be instantiated.

open-telemetry/opentelemetry-cpp#2488

@ThomsonTan ThomsonTan requested review from lalitb and a team February 17, 2024 19:22
@ThomsonTan ThomsonTan merged commit 3f1b0ef into open-telemetry:main Feb 17, 2024
1 check passed
@ThomsonTan ThomsonTan deleted the add_traceflags_to_geneva branch February 17, 2024 21:47
@marcalff marcalff added the exporter:fluentd Fluentd Exporter label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter:fluentd Fluentd Exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants