Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[geneva-exporter] add traceflag override method to fluentd exporter #385

Merged
merged 1 commit into from
Feb 17, 2024
Merged

[geneva-exporter] add traceflag override method to fluentd exporter #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions exporters/fluentd/include/opentelemetry/exporters/fluentd/trace/recordable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ class Recordable final : public sdk::trace::Recordable {
const opentelemetry::sdk::instrumentationscope::InstrumentationScope
&instrumentation_scope) noexcept override;

void SetTraceFlags(opentelemetry::trace::TraceFlags flags) noexcept override;

private:
std::string tag_;
nlohmann::json events_;
Expand Down
2 changes: 1 addition & 1 deletion exporters/fluentd/src/trace/fluentd_exporter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ FluentdExporter::FluentdExporter()
*/
std::unique_ptr<sdk::trace::Recordable>
FluentdExporter::MakeRecordable() noexcept {
return std::unique_ptr<sdk::trace::Recordable>(new Recordable);
return std::unique_ptr<sdk::trace::Recordable>(new opentelemetry::exporter::fluentd::trace::Recordable());
}

/**
Expand Down
4 changes: 4 additions & 0 deletions exporters/fluentd/src/trace/recordable.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ void Recordable::SetInstrumentationScope(
instrumentation_scope.GetVersion();
}

void Recordable::SetTraceFlags(opentelemetry::trace::TraceFlags flags) noexcept {
// TODO: process trace flags
}

} // namespace trace
} // namespace fluentd
} // namespace exporter
Expand Down