Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics SDK] Cleanup of old metrics implementation #1573

Closed
lalitb opened this issue Aug 17, 2022 · 1 comment
Closed

[Metrics SDK] Cleanup of old metrics implementation #1573

lalitb opened this issue Aug 17, 2022 · 1 comment
Assignees
@esigo
Labels
bug Something isn't working priority:p1 Issues that are blocking
Milestone
Metrics post GA r...

Comments

@lalitb
Copy link
Member

lalitb commented Aug 17, 2022 •
edited
Loading

Changes required

  • delete files under api//_metrics, sdk//_metrics directory.
  • remove ENABLE_METRICS_PREVIEW macro check in new metrics implementation.
  • remove old Prometheus exporter, old metrics ostream exporter.
  • remove examples/metrics_simple/main.cc
  • fix cmake/bazel scripts.
  • cleanup old metrics tests from CI
@lalitb lalitb added the bug Something isn't working label Aug 17, 2022
@lalitb lalitb added this to the Metrics v1.0.0 (GA) milestone Aug 17, 2022
@lalitb lalitb added the priority:p1 Issues that are blocking label Aug 24, 2022
@marcalff marcalff mentioned this issue Sep 14, 2022
Closed
@lalitb lalitb self-assigned this Nov 2, 2022
@lalitb lalitb mentioned this issue Nov 4, 2022
Merged
3 tasks
This was referenced Nov 5, 2022
Merged
Merged
@marcalff marcalff mentioned this issue Nov 7, 2022
Merged
3 tasks
@lalitb lalitb assigned esigo and unassigned lalitb Nov 21, 2022
@lalitb lalitb closed this as completed Nov 21, 2022
@lalitb
Copy link
Member Author

lalitb commented Nov 21, 2022

Already implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esigo esigo

Labels
bug Something isn't working priority:p1 Issues that are blocking
Projects
None yet
Milestone
Metrics post GA release - 1
Development

No branches or pull requests
2 participants
@lalitb @esigo