Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Cleanup ENABLE_METRICS_PREVIEW #1745

Merged
merged 1 commit into from
Nov 8, 2022
Merged

[Doc] Cleanup ENABLE_METRICS_PREVIEW #1745

merged 1 commit into from
Nov 8, 2022

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Nov 7, 2022

Fixes # (issue)

Changes

This does cleanup as part of #1573 - remove ENABLE_METRICS_PREVIEW last references.

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team November 7, 2022 23:07
lalitb
lalitb approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@lalitb lalitb merged commit b89f981 into open-telemetry:main Nov 8, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@marcalff @yxue
[Doc] Cleanup ENABLE_METRICS_PREVIEW (open-telemetry#1745)
10fcc86
@marcalff marcalff deleted the cleanup_old_metric_doc branch July 4, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcalff @ThomsonTan @lalitb