Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Add a new AddLink() operation to Span #2361

Closed
marcalff opened this issue Oct 11, 2023 · 0 comments · Fixed by #2380
Closed

[API] Add a new AddLink() operation to Span #2361

marcalff opened this issue Oct 11, 2023 · 0 comments · Fixed by #2380
Assignees
@marcalff
Labels
abi:version_2 Fix is available WITH_ABI_VERSION_2 breaking change API or ABI breaking change bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@marcalff
Copy link
Member

New spec change:

This is a breaking change (new virtual method on the span API)
@marcalff marcalff added bug Something isn't working breaking change API or ABI breaking change labels Oct 11, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 11, 2023
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 18, 2023
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Oct 19, 2023
@marcalff
Fixes open-telemetry#2361
b4ba4aa
@marcalff marcalff mentioned this issue Oct 19, 2023
Merged
3 tasks
@marcalff marcalff self-assigned this Oct 19, 2023
@marcalff marcalff added the abi:version_2 Fix is available WITH_ABI_VERSION_2 label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcalff marcalff

Labels
abi:version_2 Fix is available WITH_ABI_VERSION_2 breaking change API or ABI breaking change bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[API] Add a new AddLink() operation to Span marcalff/opentelemetry-cpp
1 participant
@marcalff