-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Add a new AddLink() operation to Span #2380
Merged
marcalff
merged 11 commits into
open-telemetry:main
from
marcalff:fix_span_addlink_2361
Oct 27, 2023
Merged
[API] Add a new AddLink() operation to Span #2380
marcalff
merged 11 commits into
open-telemetry:main
from
marcalff:fix_span_addlink_2361
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcalff
changed the title
[WIP][API] Add a new AddLink() operation to Span
[WIP] [API] Add a new AddLink() operation to Span
Oct 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #2380 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 199 199
Lines 6030 6030
=======================================
Hits 5272 5272
Misses 758 758
|
marcalff
changed the title
[WIP] [API] Add a new AddLink() operation to Span
[API] Add a new AddLink() operation to Span
Oct 22, 2023
lalitb
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Nicely done. few nit comments.
ThomsonTan
reviewed
Oct 26, 2023
esigo
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR :)
ThomsonTan
reviewed
Oct 26, 2023
ThomsonTan
reviewed
Oct 26, 2023
5 tasks
carlosalberto
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Oct 31, 2023
## Changes Update spec-compliance-matrix.md for C++: * `Get a Tracer with scope attributes` implemented by: * open-telemetry/opentelemetry-cpp#2371 * `Links can be recorded after span creation` implemented by: * open-telemetry/opentelemetry-cpp#2380 * `get_meter accepts attributes` implemented by: * open-telemetry/opentelemetry-cpp#2224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2361
Changes
Please provide a brief description of the changes here.
API
Span::AddLink() adds a single link to a span.API
Span::AddLinks() adds multiple links to a span.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes