Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no support for OTEL_SERVICE_NAME #2559

Closed
willie opened this issue Feb 27, 2024 · 2 comments · Fixed by #2577
Closed

no support for OTEL_SERVICE_NAME #2559

willie opened this issue Feb 27, 2024 · 2 comments · Fixed by #2577
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@willie
Copy link
Contributor

willie commented Feb 27, 2024

OTEL_SERVICE_NAME in the SDK configuration documentation sets the value of the service.name resource attribute.

It appears that the C++ library does not implement OTEL_SERVICE_NAME, so service.name never gets defined.
@willie willie added the bug Something isn't working label Feb 27, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 27, 2024
@lalitb
Copy link
Member

lalitb commented Feb 27, 2024 •
edited
Loading

The support for environment variable is optional as per the specs. You can specify service name directly as the resource attribute in config, or through the environment variable OTEL_RESOURCE_ATTRIBUTES.

@lalitb lalitb removed the bug Something isn't working label Feb 27, 2024
@willie
Copy link
Contributor Author

willie commented Feb 27, 2024

I guess that is a bug in the SDK docs then, as it doesn't mention any of the environmental variables as optional.

@willie willie mentioned this issue Feb 27, 2024
Closed
@willie willie mentioned this issue Mar 5, 2024
Merged
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 6, 2024
@lmolkova lmolkova mentioned this issue Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SDK] Support for OTEL_SERVICE_NAME willie/opentelemetry-cpp
3 participants
@willie @lalitb @marcalff