Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General SDK Configuration #4059

Closed
willie opened this issue Feb 27, 2024 · 6 comments
Closed

General SDK Configuration #4059

willie opened this issue Feb 27, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@willie
Copy link
Contributor

willie commented Feb 27, 2024

Apparently, environmental variables are optional, but the SDK documentation does not indicate this.

For example, the C++ SDK does not implement OTEL_SERVICE_NAME. open-telemetry/opentelemetry-cpp#2559

@cijothomas
Copy link
Member

Good point! We may need to do an audit and make sure the docs page is not promising something not implemented by the language sdks!

@svrnm svrnm added the bug Something isn't working label Feb 28, 2024
@cartermp
Copy link
Contributor

Huh, TIL. I would have figured at least OTEL_SERVICE_NAME would be required for all SDKs.

@cijothomas
Copy link
Member

Huh, TIL. I would have figured at least OTEL_SERVICE_NAME would be required for all SDKs.

Maybe its worth exploring is spec is willing to make some env variables mandatory? I am not sure what was the reason it was optional in the spec. (That'll, unfortunately, open up other heated discussion about priority - code or env-var who wins! From my own experience, languages vary in this regard)

@svrnm
Copy link
Member

svrnm commented Mar 1, 2024

From a docs perspective the first thing to do is indeed adding a disclaimer that says what is state of the spec right now, but from an overall perspective I agree that providing some more consistency here would be very end-user friendly.

@svrnm
Copy link
Member

svrnm commented Mar 1, 2024

@willie would you be willing to provide a PR with such a disclaimer?

@willie
Copy link
Contributor Author

willie commented Mar 7, 2024

Resolved by #4099

@willie willie closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants