Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove peerName() from NetServerAttributesGetter? #5395

Closed
trask opened this issue Feb 17, 2022 · 0 comments · Fixed by #5404
Closed

Remove peerName() from NetServerAttributesGetter? #5395

trask opened this issue Feb 17, 2022 · 0 comments · Fixed by #5404
Labels
enhancement New feature or request

Comments

@trask
Copy link
Member

trask commented Feb 17, 2022

Capturing NET_PEER_NAME on server spans is problematic, e.g. #5297, #5305 and #5393.

We can probably save instrumentation-api users from these problems by removing the peerName() method from NetServerAttributesGetter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove server span peer name
1 participant
@trask