Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove server span peer name #5404

Merged
merged 3 commits into from
Feb 27, 2022
Merged

Remove server span peer name #5404

merged 3 commits into from
Feb 27, 2022

Conversation

trask
Copy link
Member

@trask trask commented Feb 18, 2022

Resolves #5395

Currently this PR is built on top of #5396, will rebase once that is merged.

@trask trask marked this pull request as ready for review February 18, 2022 20:15
@trask trask requested a review from a team February 18, 2022 20:15
@trask
Copy link
Member Author

trask commented Feb 27, 2022

merging, taking @anuraaga's 👍 on the issue into consideration

@trask trask merged commit 0a6b87e into open-telemetry:main Feb 27, 2022
@trask trask deleted the remove-server-span-peer-name branch February 27, 2022 19:06
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Fix server -> client reference

* Remove server span peer name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove peerName() from NetServerAttributesGetter?
2 participants