[Hapi Plugin] Hapi instrumentation plugins wrapping issue

[jk1z]

What version of OpenTelemetry are you using?

"@opentelemetry/core": "^0.11.0",
"@opentelemetry/exporter-jaeger": "^0.11.0",
"@opentelemetry/hapi-instrumentation": "^0.10.0",
"@opentelemetry/node": "^0.11.0",
"@opentelemetry/plugin-http": "^0.11.0",
"@opentelemetry/plugin-https": "^0.11.0",
"@opentelemetry/plugin-mongodb": "^0.10.0",
"@opentelemetry/plugin-redis": "^0.10.0",
"@opentelemetry/tracing": "^0.11.0",

What version of Node are you using?

v14.2.0

What did you do?

In @Hapi version 19.1.1, when I'm trying to use server.register([{plugin: require("./plugin-a")}, require("./plugin-b")}]) while hapi-instrumentation is on. I'm getting Cannot read property 'name' of undefined from the hapi-instrumentation package.

This is because the hapi-instrumentation package only supports one of the plugin declaration format. The other declaration format are as follows:

plugin-a.js
exports.plugin = {
name: "test plugin",
....
}

What did you expect to see?

The plugin should wrap the plugins normally

What did you see instead?

It throws an error

Additional context

Hapi allows two ways of making a plugin.

[jk1z]

@carolinee21 I have raise a PR to fix this issue. Also, thanks for the hard work you put in to make this plugin.

[carolinee21]

This seems like a good add to support this other declaration format - I support adding this fix