Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrapper function for hapi route & plugins #221

Merged
merged 6 commits into from
Oct 28, 2020

Conversation

jk1z
Copy link
Contributor

@jk1z jk1z commented Oct 12, 2020

Which problem is this PR solving?

Short description of the changes

  • Fix wrapping issues in plugin and route handler

@jk1z jk1z requested a review from a team October 12, 2020 10:19
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 12, 2020

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #221 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   95.21%   95.26%   +0.04%     
==========================================
  Files         100      100              
  Lines        4979     5028      +49     
  Branches      517      526       +9     
==========================================
+ Hits         4741     4790      +49     
  Misses        238      238              
Impacted Files Coverage Δ
...de/opentelemetry-hapi-instrumentation/src/types.ts 100.00% <0.00%> (ø)
...entelemetry-hapi-instrumentation/test/hapi.test.ts 100.00% <0.00%> (ø)
...etry-hapi-instrumentation/test/hapi-plugin.test.ts 100.00% <0.00%> (ø)
...ode/opentelemetry-hapi-instrumentation/src/hapi.ts 98.48% <0.00%> (+0.04%) ⬆️

@jk1z jk1z requested a review from obecny October 14, 2020 02:10
@jk1z
Copy link
Contributor Author

jk1z commented Oct 14, 2020

@obecny I have pushed up the changes. Can I get another review please?

@jk1z jk1z requested a review from obecny October 19, 2020 23:02
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jk1z
Copy link
Contributor Author

jk1z commented Oct 22, 2020

Hi @obecny Just wondering what's the ETA on this getting merged? Would love to get this merged. Our org is using the forked version of the hapi plugin right now.

@obecny
Copy link
Member

obecny commented Oct 28, 2020

@open-telemetry/javascript-approvers ^^

@dyladan
Copy link
Member

dyladan commented Oct 28, 2020

@jk1z I can't merge this until you update the branch (or check the box that allows maintainers to update your branch 😄 )

@obecny obecny added the bug Something isn't working label Oct 28, 2020
@jk1z
Copy link
Contributor Author

jk1z commented Oct 28, 2020

@jk1z I can't merge this until you update the branch (or check the box that allows maintainers to update your branch 😄 )

That's done. 🙏

@dyladan dyladan merged commit 62c0fe8 into open-telemetry:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants