Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pino): get rid of TODO #739

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Nov 15, 2021

Which problem is this PR solving?

Removes an obsolete workaround for open-telemetry/opentelemetry-js#2131

@seemk seemk requested a review from a team November 15, 2021 12:20
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #739 (8dc0d69) into main (12718e3) will increase coverage by 0.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
+ Coverage   96.87%   97.65%   +0.77%     
==========================================
  Files          11       13       +2     
  Lines         640      852     +212     
  Branches      126      139      +13     
==========================================
+ Hits          620      832     +212     
  Misses         20       20              
Impacted Files Coverage Δ
...emetry-instrumentation-pino/src/instrumentation.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-pino/test/pino.test.ts 100.00% <0.00%> (ø)

@obecny obecny merged commit 29e4ab0 into open-telemetry:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants