Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instrumentation class _enabled #2131

Closed
obecny opened this issue Apr 20, 2021 · 2 comments
Closed

instrumentation class _enabled #2131

obecny opened this issue Apr 20, 2021 · 2 comments
Labels
feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@obecny
Copy link
Member

obecny commented Apr 20, 2021

convert private _enabled in class InstrumentationBase for node to be protected so inherited class can use it.
@obecny obecny added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Apr 20, 2021
@obecny obecny mentioned this issue Apr 20, 2021
Merged
@rauno56
Copy link
Member

rauno56 commented Apr 21, 2021

It's also something I looked for when writing restify instrumentation.

@seemk seemk mentioned this issue Apr 21, 2021
Merged
@alisabzevari
Copy link
Contributor

I think this issue should have been closed by #2135.

@seemk seemk mentioned this issue Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alisabzevari @obecny @rauno56 @vmarchaud