Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add isEnabled to InstrumentationBase #2135

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Apr 21, 2021

Which problem is this PR solving?

#2131

Short description of the changes

Instrumentations need access to the enabled flag, this is to avoid defining it multiple times.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #2135 (cf54f89) into main (4f9d2b2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head cf54f89 differs from pull request most recent head b031c3b. Consider uploading reports for the commit b031c3b to get more accurate results

@@            Coverage Diff             @@
##             main    #2135      +/-   ##
==========================================
- Coverage   92.78%   92.77%   -0.02%     
==========================================
  Files         140      140              
  Lines        4979     4981       +2     
  Branches     1028     1028              
==========================================
+ Hits         4620     4621       +1     
- Misses        359      360       +1     
Impacted Files Coverage Δ
...strumentation/src/platform/node/instrumentation.ts 23.61% <0.00%> (-0.68%) ⬇️
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@seemk
Copy link
Contributor Author

seemk commented Apr 21, 2021

Hmm, don't think I can retrigger CI without any pushes. GH actions failed due to an internal error

@seemk seemk changed the title fix: change _enabled flag to protected at InstrumentationBase fix: add isEnabled to InstrumentationBase Apr 21, 2021
@dyladan dyladan added the enhancement New feature or request label Apr 21, 2021
@dyladan
Copy link
Member

dyladan commented Apr 21, 2021

@obecny @vmarchaud need 1 more maintainer review. Would like to have this in for 0.19 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants