Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @types/node to v14 #2236

Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependency @types/node to v14 #2236

wants to merge 1 commit into from

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented May 28, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/node 8.10.66 -> 14.17.6 age adoption passing confidence
@types/node 12.20.16 -> 14.17.6 age adoption passing confidence
@types/node 10.17.60 -> 14.17.6 age adoption passing confidence

Configuration

📅 Schedule: "before 3am on Friday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #2236 (b6c2247) into main (884d20a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2236   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         145      145           
  Lines        5221     5221           
  Branches     1070     1070           
=======================================
  Hits         4844     4844           
  Misses        377      377           

@Flarna
Copy link
Member

Flarna commented May 28, 2021

@dyladan Something seems to be wrong here as @types/node in the compat tests shouldn't be updated by renovate bot.

Flarna
Flarna previously requested changes May 28, 2021
Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compat tests should stick on old node types

@Flarna
Copy link
Member

Flarna commented Jul 13, 2021

@dyladan seems renovate still tries to update node 8, 10 and 12

@dyladan
Copy link
Member

dyladan commented Jul 13, 2021

@dyladan seems renovate still tries to update node 8, 10 and 12

Yup. I wish there was some way to test renovate configs

@weyert
Copy link
Contributor

weyert commented Jul 14, 2021

@dyladan seems renovate still tries to update node 8, 10 and 12

Yup. I wish there was some way to test renovate configs

You can run the dry-run-argument to test it or pas the dryRun-parameter in the GitHub action. E.g. only let it run on the main branch

@vmarchaud vmarchaud requested a review from Flarna July 17, 2021 09:41
@vmarchaud vmarchaud dismissed Flarna’s stale review July 17, 2021 09:42

working now :)

@@ -12,7 +12,7 @@
"@opentelemetry/tracing": "0.23.0"
},
"devDependencies": {
"@types/node": "10.17.60",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backwards-compat configs should stay on the corresponding major version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well sorry i was tired i guess i though it didn't update those. Can't we just close the PR since it only want to update them ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyladan tries since a while to convince renovate-bot to do what we want. Not sure if he wants to try again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting pretty tired of trying, but it will just open another PR next time a major version is released (which admittedly doesn't happen that often)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually @types/node 15.x and 16.x exist meanwhile. But it seems bot puts all it's work into updating backward-compat to v14.

Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backwards-compat configs should stay on the corresponding major version

@vmarchaud vmarchaud self-requested a review July 21, 2021 16:08
@dyladan
Copy link
Member

dyladan commented Jul 26, 2021

I give up on the stupid renovate configs for now. Someone else is welcome to give it a try if they have the patience.

@dyladan dyladan closed this Jul 26, 2021
@forking-renovate
Copy link

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 14.x releases. However, if you upgrade to 14.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate-bot renovate-bot deleted the renovate/node-14.x branch July 26, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants