Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency @types/node to v14 #2236

Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependency @types/node to v14 #2236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backwards-compatability/node10/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@opentelemetry/tracing": "0.23.0"
},
"devDependencies": {
"@types/node": "10.17.60",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backwards-compat configs should stay on the corresponding major version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well sorry i was tired i guess i though it didn't update those. Can't we just close the PR since it only want to update them ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyladan tries since a while to convince renovate-bot to do what we want. Not sure if he wants to try again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting pretty tired of trying, but it will just open another PR next time a major version is released (which admittedly doesn't happen that often)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually @types/node 15.x and 16.x exist meanwhile. But it seems bot puts all it's work into updating backward-compat to v14.

"@types/node": "14.17.6",
"typescript": "4.3.5"
},
"author": "OpenTelemetry Authors",
Expand Down
2 changes: 1 addition & 1 deletion backwards-compatability/node12/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@opentelemetry/tracing": "0.23.0"
},
"devDependencies": {
"@types/node": "12.20.16",
"@types/node": "14.17.6",
"typescript": "4.3.5"
},
"author": "OpenTelemetry Authors",
Expand Down
2 changes: 1 addition & 1 deletion backwards-compatability/node8/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@opentelemetry/tracing": "0.23.0"
},
"devDependencies": {
"@types/node": "8.10.66",
"@types/node": "14.17.6",
"typescript": "4.3.5"
},
"author": "OpenTelemetry Authors",
Expand Down