creates CRD for OpAMPBridge resource #1559

avadhut123pisal · 2023-03-07T07:30:02Z

Related to #1368

Adds CRD for the OpAMPBridge
Adds the Mutating and Validating Webhook for the OpAMPBridge
Adds reconciliation implementation for the OpAMPBridge components

Signed-off-by: Avadhut Pisal <[email protected]>

…tor into 1368-create-operator-bridge-crd-in-operator

avadhut123pisal · 2023-03-09T16:43:38Z

jaronoff97 · 2023-03-16T02:17:12Z

@avadhut123pisal thanks for the PR going to be taking a look today and in the coming weeks. I'm currently on vacation so I'm a bit slow to respond. Thank you for your patience.

avadhut123pisal · 2023-04-04T04:10:50Z

@jaronoff97, Any update on this?

jaronoff97 · 2023-04-04T15:04:49Z

@avadhut123pisal apologies, i have been on vacation but i am back today! I'm planning on reviewing this in earnest today and this week :)

avadhut123pisal · 2023-04-04T15:10:19Z

@avadhut123pisal apologies, i have been on vacation but i am back today! I'm planning on reviewing this in earnest today and this week :)

Thanks :)

jaronoff97

Overall this is great, thanks so much for putting this together. Have a few comments about fields that may not be needed, but given this is mostly boilerplate and SUPER well tested I'm feeling pretty confident in the change. Could another @open-telemetry/operator-maintainers take a look too please?

apis/v1alpha1/opampbridge_types.go

apis/v1alpha1/opampbridge_webhook.go

config/crd/kustomization.yaml

config/crd/patches/cainjection_in_opampbridges.yaml

controllers/opampbridge_controller.go

tests/e2e/opampbridge/00-assert.yaml

…tor into 1368-create-operator-bridge-crd-in-operator

jaronoff97

Just a few more thoughts/comments

apis/v1alpha1/opampbridge_capabilities.go

apis/v1alpha1/opampbridge_types.go

apis/v1alpha1/opampbridge_webhook.go

apis/v1alpha1/opampbridge_webhook_test.go

pkg/opampbridge/serviceaccount.go

hack/modify-test-images.sh

…tor into 1368-create-operator-bridge-crd-in-operator

avadhut123pisal · 2023-10-17T09:43:04Z

Hi @jaronoff97, should we do the similar changes in this PR considering the #2210 ?

jaronoff97 · 2023-10-17T14:42:54Z

@avadhut123pisal yes, if you want. we can also do that as a follow up

…com:avadhut123pisal/opentelemetry-operator into 1368-create-operator-bridge-crd-in-operator

avadhut123pisal · 2023-10-17T15:59:19Z

@avadhut123pisal yes, if you want. we can also do that as a follow up

Yes. I will do that as a follow up.

pavolloffay

Great work! I have left some comments.

We should prefer adding smaller PRs (e.g. submit only API spec, then deployment etc..)

pavolloffay · 2023-10-19T17:03:49Z

internal/manifests/opampbridge/labels.go

+}
+
+// Labels return the common labels to all objects that are part of a managed OpAMPBridge.
+func Labels(instance v1alpha1.OpAMPBridge, name string, filterLabels []string) map[string]string {


This should be updated to #2238

It would be also possible to reuse the function by supplying objectmeta as the first parameter.

It would be also possible to reuse the function by supplying objectmeta as the first parameter.

#2254

This should be updated to #2238

Done.

pavolloffay · 2023-10-19T17:04:44Z

internal/manifests/opampbridge/deployment.go

+ ObjectMeta: metav1.ObjectMeta{
+ Name: name,
+ Namespace: params.OpAMPBridge.Namespace,
+ Labels: labels,


Annotations are not propagated? The CM propagates them.

Annotations are not propagated? The CM propagates them.

Fixed.

pavolloffay · 2023-10-19T17:06:11Z

tests/e2e/opampbridge/00-assert.yaml

Could we have a seprate test suite for opampbridge?

…tor into 1368-create-operator-bridge-crd-in-operator

jaronoff97 · 2023-10-20T15:35:21Z

Sorry the close, the "resolves" keyword in the other PR made github's logic trigger 🤦

…tor into 1368-create-operator-bridge-crd-in-operator

pavolloffay

the opampbridge e2e test suide needs to be added to makefile and enabled on GHA

…tor into 1368-create-operator-bridge-crd-in-operator

avadhut123pisal · 2023-10-25T10:22:46Z

the opampbridge e2e test suide needs to be added to makefile and enabled on GHA

Oh. Thanks. Fixed.

* creates CRD for OpAMPBridge resource * minor changes * fixes kustomization.yaml issues * adds age field to status * fixes lint issues * fixes lint issues * fixes lint issues Signed-off-by: Avadhut Pisal <[email protected]> * fixes lint issues * fix ci issues * updates bundle * fixes webhook test issue * updates bundle * updates bundle * adds enum for opamp-bridge capabilities * fix opamp server endpoint in e2e test case * fix e2e test case * fix e2e test case * validate maximum replica count * add delete verb to webhook * code refactoring to move reconciliation implementation in separate package * resolves merge conflicts * using common reconciliation implementation for opampbridge * add test cases * resolves goimports lint issues * add validations for capabilities * removes validation on specific set of capabilities * change capabilities data type to map * defaulting required capabilities * add local e2e image entry for opampbridge in hack * add OPERATOROPAMPBRIDGE_IMG to prepare-e2e * fix review comments * fix e2e hack * add e2e test-suit to github action --------- Signed-off-by: Avadhut Pisal <[email protected]>

avadhut123pisal added 13 commits March 7, 2023 12:27

creates CRD for OpAMPBridge resource

ff76304

minor changes

506292c

fixes kustomization.yaml issues

2be7eae

adds age field to status

3b5edf0

fixes lint issues

9137c1d

fixes lint issues

e3a7232

fixes lint issues

016b7d7

Signed-off-by: Avadhut Pisal <[email protected]>

fixes lint issues

d05a3e6

fix ci issues

fbed725

updates bundle

a937f57

fixes webhook test issue

cb06632

Merge branch 'main' of github.com:avadhut123pisal/opentelemetry-opera…

d7cd81a

…tor into 1368-create-operator-bridge-crd-in-operator

updates bundle

d01898a

avadhut123pisal marked this pull request as ready for review March 9, 2023 16:38

avadhut123pisal requested a review from a team March 9, 2023 16:38

avadhut123pisal added 2 commits March 11, 2023 17:07

resolves merge conflicts

bc888c8

updates bundle

099f6cd

jaronoff97 reviewed Apr 4, 2023

View reviewed changes

avadhut123pisal added 5 commits April 5, 2023 15:44

Merge branch 'main' of github.com:avadhut123pisal/opentelemetry-opera…

5b21c4f

…tor into 1368-create-operator-bridge-crd-in-operator

adds enum for opamp-bridge capabilities

439f9bc

fix opamp server endpoint in e2e test case

c4f4d2f

fix e2e test case

4ddbace

fix e2e test case

d25e3ae

avadhut123pisal requested a review from jaronoff97 April 6, 2023 06:14

jaronoff97 reviewed Apr 6, 2023

View reviewed changes

jaronoff97 reviewed Oct 13, 2023

View reviewed changes

hack/modify-test-images.sh Outdated Show resolved Hide resolved

avadhut123pisal added 4 commits October 13, 2023 20:54

Merge branch 'main' of github.com:avadhut123pisal/opentelemetry-opera…

b3145bf

…tor into 1368-create-operator-bridge-crd-in-operator

add OPERATOROPAMPBRIDGE_IMG to prepare-e2e

610d0c4

Merge branch 'main' into 1368-create-operator-bridge-crd-in-operator

e5752db

Merge branch 'main' of github.com:avadhut123pisal/opentelemetry-opera…

78b693e

…tor into 1368-create-operator-bridge-crd-in-operator

Merge branch '1368-create-operator-bridge-crd-in-operator' of github.…

3c37765

…com:avadhut123pisal/opentelemetry-operator into 1368-create-operator-bridge-crd-in-operator

pavolloffay reviewed Oct 19, 2023

View reviewed changes

Merge branch 'main' of github.com:avadhut123pisal/opentelemetry-opera…

da40730

…tor into 1368-create-operator-bridge-crd-in-operator

avadhut123pisal mentioned this pull request Oct 20, 2023

[chore] Make label functions generic #2254

Merged

jaronoff97 closed this in #2254 Oct 20, 2023

jaronoff97 reopened this Oct 20, 2023

avadhut123pisal added 3 commits October 20, 2023 22:16

Merge branch 'main' of github.com:avadhut123pisal/opentelemetry-opera…

6c989eb

…tor into 1368-create-operator-bridge-crd-in-operator

fix review comments

46950cd

fix e2e hack

35a713f

avadhut123pisal requested a review from pavolloffay October 20, 2023 17:56

srikanthccv approved these changes Oct 23, 2023

View reviewed changes

Merge branch 'main' of github.com:avadhut123pisal/opentelemetry-opera…

1804a3f

…tor into 1368-create-operator-bridge-crd-in-operator

pavolloffay reviewed Oct 25, 2023

View reviewed changes

avadhut123pisal added 2 commits October 25, 2023 15:11

add e2e test-suit to github action

cab0e6d

Merge branch 'main' of github.com:avadhut123pisal/opentelemetry-opera…

c9e28db

…tor into 1368-create-operator-bridge-crd-in-operator

pavolloffay approved these changes Oct 25, 2023

View reviewed changes

pavolloffay merged commit e8df483 into open-telemetry:main Oct 25, 2023
27 checks passed

jaronoff97 mentioned this pull request Oct 25, 2023

Create OpAMP Bridge CRD in the operator #1368

Closed

jaronoff97 mentioned this pull request Nov 7, 2023

Add agent resource type open-telemetry/semantic-conventions#396

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

creates CRD for OpAMPBridge resource #1559

creates CRD for OpAMPBridge resource #1559

avadhut123pisal commented Mar 7, 2023 •

edited

Loading

avadhut123pisal commented Mar 9, 2023

jaronoff97 commented Mar 16, 2023

avadhut123pisal commented Apr 4, 2023

jaronoff97 commented Apr 4, 2023

avadhut123pisal commented Apr 4, 2023

jaronoff97 left a comment

jaronoff97 left a comment

avadhut123pisal commented Oct 17, 2023

jaronoff97 commented Oct 17, 2023

avadhut123pisal commented Oct 17, 2023

pavolloffay left a comment

pavolloffay Oct 19, 2023

pavolloffay Oct 19, 2023

avadhut123pisal Oct 20, 2023

avadhut123pisal Oct 23, 2023

pavolloffay Oct 19, 2023

avadhut123pisal Oct 23, 2023

pavolloffay Oct 19, 2023

jaronoff97 commented Oct 20, 2023

pavolloffay left a comment

avadhut123pisal commented Oct 25, 2023

creates CRD for OpAMPBridge resource #1559

creates CRD for OpAMPBridge resource #1559

Conversation

avadhut123pisal commented Mar 7, 2023 • edited Loading

avadhut123pisal commented Mar 9, 2023

jaronoff97 commented Mar 16, 2023

avadhut123pisal commented Apr 4, 2023

jaronoff97 commented Apr 4, 2023

avadhut123pisal commented Apr 4, 2023

jaronoff97 left a comment

Choose a reason for hiding this comment

jaronoff97 left a comment

Choose a reason for hiding this comment

avadhut123pisal commented Oct 17, 2023

jaronoff97 commented Oct 17, 2023

avadhut123pisal commented Oct 17, 2023

pavolloffay left a comment

Choose a reason for hiding this comment

pavolloffay Oct 19, 2023

Choose a reason for hiding this comment

pavolloffay Oct 19, 2023

Choose a reason for hiding this comment

avadhut123pisal Oct 20, 2023

Choose a reason for hiding this comment

avadhut123pisal Oct 23, 2023

Choose a reason for hiding this comment

pavolloffay Oct 19, 2023

Choose a reason for hiding this comment

avadhut123pisal Oct 23, 2023

Choose a reason for hiding this comment

pavolloffay Oct 19, 2023

Choose a reason for hiding this comment

jaronoff97 commented Oct 20, 2023

pavolloffay left a comment

Choose a reason for hiding this comment

avadhut123pisal commented Oct 25, 2023

avadhut123pisal commented Mar 7, 2023 •

edited

Loading