Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creates CRD for OpAMPBridge resource #1559
creates CRD for OpAMPBridge resource #1559
Changes from all commits
ff76304
506292c
2be7eae
3b5edf0
9137c1d
e3a7232
016b7d7
d05a3e6
fbed725
a937f57
cb06632
d7cd81a
d01898a
bc888c8
099f6cd
5b21c4f
439f9bc
c4f4d2f
4ddbace
d25e3ae
4dcc78f
f0f3b63
57b1987
195d75b
c55da4f
da61d39
ce6cde4
4612f17
f092b71
463c918
874214e
88e74ec
5cf30e3
b0e0973
6576821
721f0d2
119de28
b8a2498
f5eb413
c0234e5
135258d
72ef9fe
f38592f
672fbbe
f71b489
4795614
b3145bf
610d0c4
e5752db
78b693e
3c37765
da40730
6c989eb
46950cd
35a713f
1804a3f
cab0e6d
c9e28db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should add the default report status to capabilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also check that the bridge has some capabilities enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specific set of capabilities ?
IMO, out of 10, these capabilities should be checked:
@jaronoff97 is it ok ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i meant that we should check that at least one capability is enabled, not a particular set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I will remove the current check. Non zero length check for the capabilities list is already there.