Skip to content

Commit

Permalink
profiles: Make mapping in Profile optional (#556)
Browse files Browse the repository at this point in the history
As commented in [0] and discussed in the OTel Profiling SIG meeting, there are situations where a main binary for a Profile can not be identified. For these cases mark the field optional.

FYI: @brancz @petethepig @open-telemetry/profiling-maintainers 

[0]: #534 (comment)
  • Loading branch information
florianl authored Sep 26, 2024
1 parent d785e67 commit a8f08fc
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ message Profile {
repeated Sample sample = 2;
// Mapping from address ranges to the image/binary/library mapped
// into that address range. mapping[0] will be the main binary.
// If multiple binaries contribute to the Profile and no main
// binary can be identified, mapping[0] has no special meaning.
repeated Mapping mapping = 3;
// Locations referenced by samples via location_indices.
repeated Location location = 4;
Expand Down

0 comments on commit a8f08fc

Please sign in to comment.