profiles: Make mapping in Profile optional #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
reviewed
May 3, 2024
opentelemetry/proto/profiles/v1experimental/pprofextended.proto
Outdated
Show resolved
Hide resolved
brancz
approved these changes
May 8, 2024
felixge
approved these changes
May 8, 2024
christos68k
approved these changes
May 8, 2024
aalexand
reviewed
May 18, 2024
opentelemetry/proto/profiles/v1experimental/pprofextended.proto
Outdated
Show resolved
Hide resolved
tigrannajaryan
previously requested changes
May 28, 2024
|
I removed my block. Let me know when the PR is ready and I can merge (all comments must be resolved before merging). |
|
Is this PR still in progress? |
As commented in [0] and discussed in the OTel Profiling SIG meeting, there are situations where a main binary for a Profile can not be identified. For these cases mark the field optional. [0]: open-telemetry#534 (comment) Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
florianl
force-pushed
the
flo-profiles-main-exec
branch
from
30ba804
to
f6f0f7e
Compare
|
I had to force-push changes to resolve conflicts, that were introduced by the changes in #585. |
jhalliday
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented in 0 and discussed in the OTel Profiling SIG meeting, there are situations where a main binary for a Profile can not be identified. For these cases mark the field optional.
FYI: @brancz @petethepig @open-telemetry/profiling-maintainers