Make it possible to indicate partial success in an OTLP export response [2] #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a second attempt in solving/addressing open-telemetry/opentelemetry-specification#2454. This uses the
rejected
semantics instead ofaccepted
as discussed in the initial PR #390.Related spec PR: open-telemetry/opentelemetry-specification#2696
The need for this new PR was that with
accepted
we were running into problems with the0
value being the same as the default/not set, plus general intention to avoid havingoptional
on the fields.I did some tests with sample apps to confirm the cases for backwards compatibility. Those can be checked in: joaopgrassi/otlp-partial-success-experimental. The TL;DR: Since it's a new field no breaking change is introduced. New sender will always have to check if the
partial_success
is set because they can be working with servers using the old protos.Some context on why this feature is desired:
This feature IS intended to help in the following scenarios:
400 - BadRequest
(status quo today)otlp.exporter.rejected.data_points=x
)This feature IS NOT intended to help in the following scenarios:
cc @tigrannajaryan @jmacd @jsuereth @jack-berg @reyang