Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update OpenTelemetry Protobuf Definitions to v1.0.0 #19188

Merged

Conversation

hdost
Copy link
Contributor

@hdost hdost commented Nov 17, 2023

This will also make sure that all the necessary files exist for the rest of the signals.

Relates #1444
Signed-off-by: Harold Dost [email protected]

Not expected to be a breaking change to open-telemetry/opentelemetry-proto#414

@hdost hdost requested a review from a team November 17, 2023 19:53
@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Nov 17, 2023
@bits-bot
Copy link

bits-bot commented Nov 17, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@StephenWakely StephenWakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@StephenWakely
Copy link
Contributor

@hdost We have some very trivial checks that have failed. Would you be able to amend these:

cargo vdev check fmt
File "lib/opentelemetry-proto/src/proto/opentelemetry-proto/opentelemetry/proto/collector/logs/v1/logs_service_http.yaml" doesn't end with a newline
File "lib/opentelemetry-proto/src/proto/opentelemetry-proto/opentelemetry/proto/collector/metrics/v1/metrics_service_http.yaml" doesn't end with a newline
File "lib/opentelemetry-proto/src/proto/opentelemetry-proto/opentelemetry/proto/common/v1/common.proto" contains trailing spaces in some of the lines

@hdost
Copy link
Contributor Author

hdost commented Nov 21, 2023

Yup I should be able tomorrow morning.

This will also make sure that all the necessary files exist for the rest of the signals.

Relates vectordotdev#1444
Signed-off-by: Harold Dost <[email protected]>
@hdost hdost force-pushed the bump-opentelemetry-source-protos branch from e066125 to 402da80 Compare November 22, 2023 13:27
@hdost
Copy link
Contributor Author

hdost commented Nov 23, 2023

@StephenWakely should be set

@StephenWakely StephenWakely added this pull request to the merge queue Nov 23, 2023
Copy link

Regression Detector Results

Run ID: dd0bedfe-e18f-44cc-98c1-c238bae8a620
Baseline: 5a0966a
Comparison: 24034c7
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
otlp_grpc_to_blackhole ingress throughput +1.62 [+1.52, +1.73] 100.00%
datadog_agent_remap_datadog_logs ingress throughput +1.44 [+1.35, +1.53] 100.00%
datadog_agent_remap_blackhole ingress throughput +1.40 [+1.31, +1.48] 100.00%
datadog_agent_remap_datadog_logs_acks ingress throughput +1.21 [+1.14, +1.29] 100.00%
syslog_regex_logs2metric_ddmetrics ingress throughput +1.15 [+1.07, +1.24] 100.00%
datadog_agent_remap_blackhole_acks ingress throughput +0.59 [+0.50, +0.68] 100.00%
file_to_blackhole egress throughput +0.46 [-1.99, +2.91] 24.28%
http_elasticsearch ingress throughput +0.24 [+0.17, +0.30] 100.00%
syslog_log2metric_humio_metrics ingress throughput +0.22 [+0.13, +0.30] 100.00%
http_to_http_noack ingress throughput +0.17 [+0.07, +0.26] 99.69%
syslog_log2metric_splunk_hec_metrics ingress throughput +0.15 [+0.03, +0.28] 95.33%
http_to_s3 ingress throughput +0.12 [-0.15, +0.39] 53.53%
http_to_http_json ingress throughput +0.03 [-0.04, +0.10] 47.06%
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.14, +0.14] 3.02%
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.13, +0.14] 1.80%
splunk_hec_route_s3 ingress throughput +0.00 [-0.50, +0.50] 0.06%
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.06 [-0.17, +0.06] 56.90%
fluent_elasticsearch ingress throughput -0.12 [-0.58, +0.35] 32.13%
enterprise_http_to_http ingress throughput -0.12 [-0.22, -0.02] 94.56%
syslog_humio_logs ingress throughput -0.17 [-0.25, -0.08] 99.83%
syslog_loki ingress throughput -0.41 [-0.45, -0.37] 100.00%
http_to_http_acks ingress throughput -0.75 [-2.05, +0.55] 65.68%
syslog_splunk_hec_logs ingress throughput -0.81 [-0.85, -0.77] 100.00%
otlp_http_to_blackhole ingress throughput -2.30 [-2.44, -2.17] 100.00%
socket_to_socket_blackhole ingress throughput -2.33 [-2.38, -2.27] 100.00%
http_text_to_http_json ingress throughput -2.69 [-2.82, -2.56] 100.00%

Merged via the queue into vectordotdev:master with commit 24034c7 Nov 23, 2023
39 checks passed
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
…dev#19188)

This will also make sure that all the necessary files exist for the rest of the signals.

Relates vectordotdev#1444
Signed-off-by: Harold Dost <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sources Anything related to the Vector's sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants