-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to know a parent is remote when starting a span #187
Comments
Based on the Java implementation it does appear the decision is based on if the parent is a Span or SpanContext. This doesn't work well for at least the Erlang implementation where the user will only ever have the context for use as a parent. I think there should be a explicit |
Typically, a |
@mwear yea, that is what OpenCensus did. For now I'm adding a How to propose adding this officially to the |
Whether or not the parent of a span that is being started is remote is an attribute that must be passed to samplers.
Span creation docs do mention remote parents but it isn't clear how it is deciding it is remote:
Why is it assumed that
parentCtx
is remote here?In OpenCensus we had a optional remote parent flag that could be set when calling
start_span
.The text was updated successfully, but these errors were encountered: