Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics compliance matrix #1956

Merged
merged 19 commits into from
Oct 26, 2021
Merged

Add metrics compliance matrix #1956

merged 19 commits into from
Oct 26, 2021

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Sep 22, 2021

Fixes #1953

@ocelotl ocelotl force-pushed the issue_1953 branch 2 times, most recently from c10277d to de4b764 Compare September 22, 2021 17:53
@ocelotl ocelotl marked this pull request as ready for review September 22, 2021 17:53
@ocelotl ocelotl requested review from a team September 22, 2021 17:53
@ocelotl ocelotl force-pushed the issue_1953 branch 2 times, most recently from 3c909f7 to 92e5fca Compare September 22, 2021 18:10
tigrannajaryan
tigrannajaryan reviewed Sep 22, 2021
View reviewed changes
table_generator.py Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang reviewed Sep 24, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
reyang
reyang previously requested changes Sep 24, 2021
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find my comments.

@reyang reyang added spec:metrics Related to the specification/metrics directory area:miscellaneous For issues that don't match any other area label labels Sep 24, 2021
@reyang reyang added this to the Metrics API/SDK Feature Freeze milestone Sep 24, 2021
@reyang reyang dismissed their stale review September 25, 2021 19:39

All the blocking comments were resolved.

jsuereth
jsuereth reviewed Sep 27, 2021
View reviewed changes
spec-compliance-matrix.md Outdated Show resolved Hide resolved
ocelotl and others added 16 commits October 22, 2021 10:49
@ocelotl
Add metrics compliance matrix
8ceff4a
@ocelotl
Remove table generator
cca58e7
@ocelotl @reyang
Update spec-compliance-matrix.md
f70188c 
Co-authored-by: Reiley Yang <[email protected]>
@ocelotl @reyang
Update spec-compliance-matrix.md
8c4157a 
Co-authored-by: Reiley Yang <[email protected]>
@ocelotl
Remove requirement
ac5b6b9
@ocelotl @reyang
Update spec-compliance-matrix.md
8559136 
Co-authored-by: Reiley Yang <[email protected]>
@ocelotl @reyang
Update spec-compliance-matrix.md
25a0762 
Co-authored-by: Reiley Yang <[email protected]>
@ocelotl @reyang
Update spec-compliance-matrix.md
ceec30a 
Co-authored-by: Reiley Yang <[email protected]>
@ocelotl @reyang
Update spec-compliance-matrix.md
ddf1b91 
Co-authored-by: Reiley Yang <[email protected]>
@ocelotl @reyang
Update spec-compliance-matrix.md
4d183f2 
Co-authored-by: Reiley Yang <[email protected]>
@ocelotl @reyang
Update spec-compliance-matrix.md
af91da0 
Co-authored-by: Reiley Yang <[email protected]>
@ocelotl @reyang
Update spec-compliance-matrix.md
ff58e3d 
Co-authored-by: Reiley Yang <[email protected]>
@jmacd @arminru @ocelotl
Update spec-compliance-matrix.md
abc91bc 
Co-authored-by: Armin Ruech <[email protected]>
@jmacd @arminru @ocelotl
Update spec-compliance-matrix.md
f58dcdd 
Co-authored-by: Armin Ruech <[email protected]>
@ocelotl @jmacd
Update spec-compliance-matrix.md
97ee7df 
Co-authored-by: Joshua MacDonald <[email protected]>
@ocelotl
Fix document status path
6abfbdc
@ocelotl
Copy link
Contributor Author

ocelotl commented Oct 22, 2021

@reyang @jsuereth I have removed all mentions of exemplars, any other lines that had objections and added a disclaimer 👍

Please let me know if you need more changes.

@github-actions github-actions bot removed the Stale label Oct 23, 2021
hdost
hdost approved these changes Oct 23, 2021
View reviewed changes
Copy link

@hdost hdost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that my approval does anything.

@reyang
Copy link
Member

reyang commented Oct 26, 2021

@jsuereth I think this is ready to be merged based on the discussion last week.

@reyang reyang mentioned this pull request Oct 26, 2021
Merged
@jsuereth jsuereth enabled auto-merge (squash) October 26, 2021 16:06
@jsuereth jsuereth merged commit 322cac1 into open-telemetry:main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan left review comments

@arminru arminru arminru left review comments

@jsuereth jsuereth jsuereth approved these changes

@hdost hdost hdost approved these changes

@reyang reyang reyang approved these changes

Assignees

@jmacd jmacd

@arminru arminru

Labels
area:miscellaneous For issues that don't match any other area label spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
Metrics API/SDK Feature Freeze
Development

Successfully merging this pull request may close these issues.

Create metrics feature spec compliance matrix
7 participants
@ocelotl @jmacd @reyang @jsuereth @hdost @tigrannajaryan @arminru