Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Metrics SDK spec to Feature-freeze #2057

Merged
merged 4 commits into from
Oct 28, 2021
Merged

Move Metrics SDK spec to Feature-freeze #2057

merged 4 commits into from
Oct 28, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Oct 26, 2021

Once #2032 and #1956 are merged, we are ready to mark the metrics SDK spec as Feature-freeze.

@reyang reyang requested review from a team October 26, 2021 02:13
@reyang reyang added spec:metrics Related to the specification/metrics directory area:sdk Related to the SDK labels Oct 26, 2021
@reyang reyang added this to the Metrics API/SDK Feature Freeze milestone Oct 26, 2021
@jsuereth
Copy link
Contributor

I don't think we need to wait for the feature matrix before freezing metrics here...

@jsuereth
Copy link
Contributor

FYI - This does leave out the "Prometheus Exporter" specificaton from the SDK feature freeze. Are we tracking that document status separately?

@tigrannajaryan
Copy link
Member

FYI - This does leave out the "Prometheus Exporter" specificaton from the SDK feature freeze. Are we tracking that document status separately?

Also OTLP metric exporter document. For traces we did track Jaeger and Zipkin separately, so I think it is fine to continue the same practice for metric exporters.

@reyang
Copy link
Member Author

reyang commented Oct 26, 2021

FYI - This does leave out the "Prometheus Exporter" specification from the SDK feature freeze. Are we tracking that document status separately?

Yes, each exporter has its own status.

@carlosalberto
Copy link
Contributor

@reyang The related PRs have been merged. Do you want to wait a little bit more or can we merge already?

@reyang
Copy link
Member Author

reyang commented Oct 28, 2021 •
edited
Loading

@reyang The related PRs have been merged. Do you want to wait a little bit more or can we merge already?

I think we're good to merge this PR.
We still have room to fix bugs & improve wording. It just communicates that we won't be adding new features between now and Stable.

@carlosalberto carlosalberto merged commit 8d75218 into open-telemetry:main Oct 28, 2021
@carlosalberto
Copy link
Contributor

Thanks @reyang, merged!

@reyang reyang deleted the reyang/metrics-sdk-feature-freeze branch April 17, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@jmacd jmacd jmacd approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
Metrics API/SDK Feature Freeze
Development

Successfully merging this pull request may close these issues.
7 participants
@reyang @jsuereth @tigrannajaryan @carlosalberto @jmacd @cijothomas @bogdandrutu