Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't generate frontend specific urls for the Learner Record MFE #276

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

justinhynes
Copy link
Contributor

[APER-1975]

All links to public program records will point to the Credentials IDA and the backend will figure out whether it should be redirected to the legacy FE or the LR MFE. This also removes the RECORDS_BASE_URL setting which we no longer need.

[APER-1975]

All links to public program records will point to the Credentials IDA and the backend will figure out whether it should be redirected to the legacy FE or the LR MFE. This also removes the `RECORDS_BASE_URL` setting which we no longer need.
@justinhynes justinhynes marked this pull request as ready for review October 19, 2022 12:16
Copy link
Member

@MaxFrank13 MaxFrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just merged my changes to this MFE but I don't think there are any conflicts (I assume Github would scream at us?)

@justinhynes
Copy link
Contributor Author

Yeah, you're right. If there were any conflicts, it should get picked up here. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants