Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't generate frontend specific urls for the Learner Record MFE #276

Merged
merged 1 commit into from
Oct 19, 2022
Merged

fix: don't generate frontend specific urls for the Learner Record MFE #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ LOGIN_URL=null
LOGOUT_URL=null
MARKETING_SITE_BASE_URL=null
ORDER_HISTORY_URL=null
RECORDS_BASE_URL=null
REFRESH_ACCESS_TOKEN_ENDPOINT=null
SEGMENT_KEY=null
SITE_NAME=null
Expand Down
1 change: 0 additions & 1 deletion .env.development
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg/
FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico
MARKETING_SITE_BASE_URL='http://localhost:18000'
ORDER_HISTORY_URL='localhost:1996/orders'
RECORDS_BASE_URL='localhost:1990'
REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh'
SEGMENT_KEY=null
SITE_NAME='edX'
Expand Down
1 change: 0 additions & 1 deletion .env.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ LOGIN_URL='http://localhost:18000/login'
LOGOUT_URL='http://localhost:18000/logout'
MARKETING_SITE_BASE_URL='http://localhost:18000'
ORDER_HISTORY_URL='localhost:1996/orders'
RECORDS_BASE_URL='localhost:1990'
REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh'
SEGMENT_KEY=null
SITE_NAME='edX'
Expand Down
1 change: 0 additions & 1 deletion src/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import './index.scss';

mergeConfig({
LICENSE_MANAGER_URL: process.env.LICENSE_MANAGER_URL,
RECORDS_BASE_URL: process.env.RECORDS_BASE_URL,
USE_LEARNER_RECORD_TAB: process.env.USE_LEARNER_RECORD_TAB,
});

Expand Down
1 change: 0 additions & 1 deletion src/setupTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Enzyme.configure({ adapter: new Adapter() });

mergeConfig({
LICENSE_MANAGER_URL: process.env.LICENSE_MANAGER_URL,
RECORDS_BASE_URL: process.env.RECORDS_BASE_URL,
USE_LEARNER_RECORD_TAB: process.env.USE_LEARNER_RECORD_TAB,
});

Expand Down
4 changes: 2 additions & 2 deletions src/users/LearnerRecords.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import messages from './messages';
function LearnerRecords({ username, intl }) {
const [records, setRecords] = useState(null);
const [error, setError] = useState(null);
const { RECORDS_BASE_URL } = getConfig();
const { CREDENTIALS_BASE_URL } = getConfig();

useEffect(() => {
if (username) {
Expand All @@ -26,7 +26,7 @@ function LearnerRecords({ username, intl }) {
}, [username]);

const handleCopyButton = (uuid) => {
navigator.clipboard.writeText(`${RECORDS_BASE_URL}/shared/${uuid}`);
navigator.clipboard.writeText(`${CREDENTIALS_BASE_URL}/records/programs/shared/${uuid}`);
};

const renderStatus = (program) => {
Expand Down