-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: bifacial_radiance: a python package for modeling bifacial solar photovoltaic systems #1865
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @wholmgren, @dalonsoa it looks like you're currently assigned to review this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https:/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Acceptance-blocker due to limited/incomplete installation instructions NREL/bifacial_radiance#190 |
Not exactly an acceptance-blocker, but certainly desirable to understand how the software works NREL/bifacial_radiance#191 |
Acceptance-blocker due to missing statement of need (or more specifically, intended audience) NREL/bifacial_radiance#192 |
Not an acceptance blocker, but it will be useful for the authors to elaborate NREL/bifacial_radiance#193 |
@melissawm It seems there’s a figure missing in the Software Paper. It is present in the repository and it appears when showing the markdown file of the paper in GitHub but it is not rendered when creating the PDF. I'm not sure of the reason for that. |
@melissawm The license of the software is |
I think it does matter, yes. Sorry for not catching this before. @shirubana could you clarify? I'll check about the picture. Thanks! |
Well the DOI paper was published in 2017 when we started and it seems we changed the license to BSD-3 1 year ago, as per the github history of the file... @cdeline can you confirm if BSD-3 is what we will go on forever now and/or if we need to consolidate? I think a simple solution would be to write a note of the switch on the documentation (maybe on the updates, package overview and/or contribution guidelines). |
Yes, we’re using a BSD-3 license for the software for now and forever more.
Chris Deline
National Renewable Energy Laboratory
(303) 384-6359
From: Silvana Ayala <[email protected]>
Sent: Thursday, November 7, 2019 2:05 PM
To: openjournals/joss-reviews <[email protected]>
Cc: Deline, Chris <[email protected]>; Mention <[email protected]>
Subject: Re: [openjournals/joss-reviews] [REVIEW]: bifacial_radiance: a python package for modeling bifacial solar photovoltaic systems (#1865)
Well the DOI paper was published in 2017 when we started and it seems we changed the license to BSD-3 1 year ago, as per the github history of the file... @cdeline<https:/cdeline> can you confirm if BSD-3 is what we will go on forever now and/or if we need to consolidate?
I think a simple solution would be to write a note of the switch on the documentation (maybe on the updates, package overview and/or contribution guidelines).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1865?email_source=notifications&email_token=AFRK2OA6BQYCBRYTK7UCXPDQSR7HZA5CNFSM4JJE6BX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDNZXKY#issuecomment-551263147>, or unsubscribe<https:/notifications/unsubscribe-auth/AFRK2OCVSMKMRJGHXQOH5U3QSR7HZANCNFSM4JJE6BXQ>.
|
@melissawm the COI policy states:
@shirubana was a graduate student at my organization, University of Arizona, from 2012- Dec 2018. So there is 1-2 month overlap over the past year. But, the COI policy also states as an example of when a waiver can be granted:
We knew of each other but very rarely interacted. Different departments, siloed research programs. I wouldn't have any problem providing an impartial review of this paper. |
Also on the subject of the license, it includes this NREL specific language:
Does this violate the requirement "Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?" My own opinion is "no" but seems like a question for the editors. |
@wholmgren - the conflict you describe is weak enough that it can be waived, but thank you for making this possible issue transparent. |
Thank you all for your patience while I was checking this. As far as the change in licensing, a note in the documentation would be ok. However, as far as the NOTICE mentioned above by @wholmgren , the best solution would be to remove it from the licence file (mantaining it a pure BSD 3 license) and adding this note somewhere in the project (for example, in the README). @shirubana do you think this is feasible? Please let me know if you have further questions or comments. |
@cdeline would this option of using the README instead of the License file to have the sponsoring/DOE acknowledgment work to satisfy NREL's legal stuff? |
Hi everybody! I'm investigating these two points with the legal team here at NREL, but for everyone's information, a LICENSE file wasn't added until v0.2.3 on 11/14/2018, and it was initiated as a BSD-3 license, and has remained the same since then. So, I believe the DOI entry is incorrect and should probably be updated - there are a couple of other inaccuracies there including that we were supported by the CEC. |
Hi all, i've been given approval by NREL legal to replace LICENSE.txt with a stock BSD-3 from the OSI webpage. I'm merging that in Master now. |
Thank you, @cdeline and @shirubana! @wholmgren and @dalonsoa this means the review can resume as normal. If you have any further questions, don't hesitate to ask! |
👋 @melissawm - I'm just checking in on the progress of this review |
I'm waiting for some changes to be made in this PR NREL/bifacial_radiance#199 before I can tick all the remaining boxes in the review. It seems that the PR is not passing all checks for now, so no sure what is the status of the review. |
sorry! I'll do this today. I hadn't realized that. ugh. |
@dalonsoa @danielskatz @wholmgren I have addressed all of issues and the PR comments now as well. |
I'll tick those things that have been solved... but the PR is still not passing 🤷♂ . |
ok now we're good :) |
@whedon generate pdf |
I liked.... hmmm one of the titles disapeared. |
@whedon generate pdf |
@whedon generate pdf |
@kyleniemeyer ok I'm good , all references have DOI if they have them now. |
@whedon accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1474 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1474, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
Hey @arfon, this is now ready for the name fix, both in the paper footer and the citation on the landing page. |
Congrats @shirubana on your article's publication in JOSS! Many thanks to @wholmgren, @dalonsoa, and @usethedata for reviewing this, and @melissawm for editing. |
Thank you all for working on this, especially @kyleniemeyer for taking over since I was unavailable. Congratulations @shirubana ! |
thank you for this! everyone!!!! this is really great :) |
@arfon if you get a chance to update the last name on the footer and webpage --- to "Ayala Pelaez" instead of just Pelaez :) t |
Sure thing. I can do that - I might not be able to get to this until tomorrow though sorry. |
@shirubana - this should be updated now although the PDF may take a while to update as it's cached. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @shirubana (Silvana Ayala Pelaez)
Repository: https:/NREL/bifacial_radiance/
Version: v0.3.3.1
Editor: @melissawm
Reviewers: @wholmgren, @dalonsoa, @usethedata
Archive: 10.5281/zenodo.3860350
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@wholmgren ,@dalonsoa and @usethedata please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @melissawm know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @wholmgren
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @dalonsoa
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @usethedata
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: