Adds initial type service

[ashwin-pc]

Signed-off-by: Ashwin Pc [email protected]

Description

The initial work in progress code for TypeService. Allows for adding new visualization types for the Drag and Drop experience in a consistent manner.

Next steps:

• Add contributions
• work with expressions
• tests and documentation

Issues Resolved

#952

Check List

• New functionality includes testing.
  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
• New functionality has been documented.
• Commits are signed per the DCO using --signoff

[kavilla]

typeServieSetup

[kavilla]

No description required?

[ashwin-pc]

This is still WIP. So ive just put a placeholder here for now to activate the type picker and make sure that it works

[kavilla]

Looking good!

I have few questions though and apologies if you answered this in another location. I understand we probably want to slowly add more and more support for more visualizations but how come we can't use Types Service within the visualizations plugin here, and perhaps filter by supported types?

Secondly, although the tooltip looks cool, does selection of types render better with a dropdown selection? How long does this list expected to be when finalized?

Thanks !

[ashwin-pc]

Thanks a ton for taking a look at this. Always happy to answer questions 😄

I understand we probably want to slowly add more and more support for more visualizations but how come we can't use Types Service within the visualizations plugin here, and perhaps filter by supported types?

The type service that you refer to is specific to the visualize app. It has attributes and properties that only make sense to it and adding the properties that Drag and Drop needs on top of that will only make an already confusing service even more unwieldy. since its mostly a glorified dictionary, creating a new one instead of reusing it made a lot more sense. We do use it though to register the entry point to the Drag and Drop experience.

Secondly, although the tooltip looks cool, does selection of types render better with a dropdown selection? How long does this list expected to be when finalized?

If you are talking about the tooltip as it exists today, it is just a place holder. The final selector should look like this. A drop down can work here, but I'm not sure why we want to make that UX sacrifice. Maybe i'm just missing something here but let me know if this doesn't make sense to you.

[kavilla]

The type service that you refer to is specific to the visualize app. It has attributes and properties that only make sense to it and adding the properties that Drag and Drop needs on top of that will only make an already confusing service even more unwieldy. since its mostly a glorified dictionary, creating a new one instead of reusing it made a lot more sense. We do use it though to register the entry point to the Drag and Drop experience.

I might be a little bit more confused seeing two visualization services, but I'll defer to your opinion.

[kavilla]

If you are talking about the tooltip as it exists today, it is just a place holder. The final selector should look like this. A drop down can work here, but I'm not sure why we want to make that UX sacrifice. Maybe i'm just missing something here but let me know if this doesn't make sense to you.

Sounds good.