-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[D&D] Adds drop validation #1833
[D&D] Adds drop validation #1833
Conversation
Signed-off-by: Ashwin Pc <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and comments, but feel free to merge and keep the ball rolling.
if (!data || !validAggTypes.length) { | ||
throw new Error('Cannot drop field here, missing drop properties'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a UX perspective, it seems like it would be better to determine the valid drop targets on the drag start event rather than waiting until the drop to declare it invalid. If we did that, we could highlight only valid drop targets, making it clear to the user where that field can go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. The user will never see this error. It will fail silently and only be logged in the console. The isValidDropTarget property returned by this hook is what actually indicates to the user that the field is droppable. And that is set when the drag begins. I just threw an error here for the console instead of failing silently if the user decided to ignore the UI indicators, but ill revert that. The error does not make sense here anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, that's helpful context.
|
||
aggConfigs?.createAggConfig({ | ||
type: (schema.defaults as any).aggType, | ||
type: allowedAggTypes[0] || validAggTypes[0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still catching up to some of the concepts in d&d, but why would we want to create an aggConfig
even if there are no allowedAggTypes
in the schema? Is it because schemas aren't required to define allowedAggTypes
? If that's the case, why couldn't we just set L133 to validAggTypes
and avoid the fallback here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question. To understand the logic here, let me back up a bit since it took me a while to figure it out myself. On app start, the agg service registers a variety of aggregation types like avg, max, etc. But each schema has filters for the agg types they support and each aggtype has filters for the field types they support. So validAggTypes
is an array of all the agg types that the field being dragged can be used with, and if there is atleast one of them, then we should be able to drop the field into that dropbox.
allowedAggTypes
is a subset of validAggTypes
where the aggTypes defined in schema.defaults
are also present in validAggTypes
. So the logic is that we use the default aggType thats also present in validAggTypes
, but if that isnt possible, we just use the first agg type from validAggTypes
as a fallback.
|
||
allowedAggTypes.forEach((aggType) => { | ||
const allowedFieldTypes = aggType.paramByName('field')?.filterFieldTypes; | ||
const isFieldDroppable = filterByType([indexField], allowedFieldTypes).length !== 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - this name doesn't need to include Droppable
- this test is more generic, something like isFieldAllowed
or something like that. I also kind of think this would be more readable if written with reduce()
instead of forEach()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of reduce, but i do agree with the readability. Ive refactored this to just use the filter and map functions.
@@ -154,17 +164,36 @@ export const useDropbox = (props: UseDropboxProps): DropboxProps => { | |||
onDropField | |||
); | |||
|
|||
const isValidDropField = useMemo(() => { | |||
if (!dragData) return false; | |||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hook should probably be a separate file, partly because it looks like it will require substantial unit tests to verify all the edge cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. Ill leave it in here for this PR. I am yet to add another validation for min and max values. Once i do that, ill move it out with some tests.
Signed-off-by: Ashwin Pc <[email protected]>
* edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]>
* edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]>
* edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]>
* edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]>
* edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]>
* edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]>
* edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]>
* edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]>
* edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]>
* [Chore] Moves Drag and Drop to new branch (#1400) * Initial Drag and Drop plugin code (#946) * Initial Drag and Drop plugin code Signed-off-by: Ashwin Pc <[email protected]> * Adds state management to Drag and Drop Signed-off-by: Ashwin Pc <[email protected]> * Moves Drag and Drop to create visualization menu Signed-off-by: Ashwin Pc <[email protected]> * Field Search in Data panel (#995) Add ability to search on index fields Signed-off-by: Abbas Hussain <[email protected]> * Adds initial type service (#1260) Signed-off-by: Ashwin Pc <[email protected]> * chore: updates viz modal snapshot Signed-off-by: Ashwin Pc <[email protected]> * fix(License): Fixes license headers Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> * [D&D] Type Service Contributions (#1402) * feat(Contributions): Simple working contributions Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Add new field from dropbox Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Working edit mode Signed-off-by: Ashwin Pc <[email protected]> * fix(Contributions): Fixes switching dropbox fields Signed-off-by: Ashwin Pc <[email protected]> * chore: Updates license headers Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Adds initial drag & drop validation Signed-off-by: Ashwin Pc <[email protected]> * feat(Dropbox): Allows multiple instances of the same field Signed-off-by: Ashwin Pc <[email protected]> * feat(Dropbox): Working reorder fields Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Working container contributions Signed-off-by: Ashwin Pc <[email protected]> * chore: clean up exports Signed-off-by: Ashwin Pc <[email protected]> * test(Contribution): Adds unit test `mergeArrays` Signed-off-by: Ashwin Pc <[email protected]> * test(TypeService): Adds plugin unit tests Signed-off-by: Ashwin Pc <[email protected]> * chore: remove redundant code Signed-off-by: Ashwin Pc <[email protected]> * test(Functional): Updates Chart types Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Refactor to use AggService and introduce metric visualization (#1734) * partial progress Signed-off-by: Ashwin Pc <[email protected]> * simle workign metric using aggShemas Signed-off-by: Ashwin Pc <[email protected]> * updated VisualizationTypeOptions to be a generic Signed-off-by: Ashwin Pc <[email protected]> * partially working metric style options Signed-off-by: Ashwin Pc <[email protected]> * all state objects are serializeable Signed-off-by: Ashwin Pc <[email protected]> * working delete and reorder Signed-off-by: Ashwin Pc <[email protected]> * chore: cleanup agg service changes Signed-off-by: Ashwin Pc <[email protected]> * Adds the data source selector and a useIndexPatterns hook (#1763) Signed-off-by: Brooke Green <[email protected]> * [D&D] Adding and editing an aggregation + metric color ranges (#1781) * edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * cleanup dropbox field icon Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * Updated comment Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Enable basic saved object management (#1816) * [D&D] Enable basic saved object management - Create README stub for saved_objects_management plugin - Register wizard saved object loader with management plugin - Add management methods to SavedObjectsType - Add capabilities provider to wizard - Add saved wizard vis SavedObjectClass and SavedObjectLoader - Add public plugin start method partially addresses #1620 Signed-off-by: Josh Romero <[email protected]> * [Doc] Add clarifications to README for save objects management plugin Signed-off-by: Josh Romero <[email protected]> * [D&D] Adds drop validation (#1833) * edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]> * chore: updates D&D icon (#1844) Signed-off-by: Ashwin Pc <[email protected]> * Chore/remove contributions (#1843) * adds min/max validation Signed-off-by: Ashwin Pc <[email protected]> * relocated contributions Signed-off-by: Ashwin Pc <[email protected]> * Some more cleanup Signed-off-by: Ashwin Pc <[email protected]> * minor fixes Signed-off-by: Ashwin Pc <[email protected]> * one more unnecessary file Signed-off-by: Ashwin Pc <[email protected]> * fix: Seconday panel title Signed-off-by: Ashwin Pc <[email protected]> * chore: Updates Field selector (#1845) Signed-off-by: Ashwin Pc <[email protected]> * Adding breadcrumbs for drag and drop creation (#1797) Signed-off-by: Brooke Green <[email protected]> * fix(D&D): fixes reloading app (#1855) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Dropbox style and animations (#1863) * fix dropbox styles and added animations Signed-off-by: Ashwin Pc <[email protected]> * simpler usePrefersReducedMotion Signed-off-by: Ashwin Pc <[email protected]> * fix drop target animation Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Basic saving, loading, and updating (#1870) * [D&D] Enable basic saving and loading - Add `/edit` route - Sync state for saving and loading - Add setter for vizualization slice - Switch from BrowserRouter to Router - Add version to saved objects - Add savedWizardLoader to services - store visualization and style states separately - add version - update breadcrumb handling - move useSavedWizardVis to top_nav - handle savedObjectNotFound - use savedObjectLoader correctly - allow copy on save - update url and chrome on save - add type for WizardVisSavedObject fixes #1867 Signed-off-by: Josh Romero <[email protected]> * chore: Adds a few readme's (#1894) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Empty-workspace polish (#1900) * empty workspace polish Signed-off-by: kaddy645 <[email protected]> * pr update Signed-off-by: kaddy645 <[email protected]> * pr update 2 Signed-off-by: kaddy645 <[email protected]> * [D&D] Fix: Topnav updates aggregation parameters (#1905) * fix(D&D): Fixes top nav query and timerange Signed-off-by: Ashwin Pc <[email protected]> * fix(D&D): Handles topnav state update Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Add a flag in the YAML config to enable and disable the D&D plugin (#1889) Resolves Issue - #1877 Signed-off-by: Manasvini B Suryanarayana <[email protected]> * fix(Workspace): Fixes illustration and copy (#1916) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Misc fixes (#1924) * fix: minor fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: nit syntax fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: simplify useSavedWizardVis Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Enable basic embeddable panels (#1911) - add embeddable, embeddable component, embeddable factory - update `toExpression` to allow passing services - register embeddable factory in plugin setup fixes #1908 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix scss lint and available fields (#1927) * fix(Lint): fixes scss linting issues Signed-off-by: Ashwin Pc <[email protected]> * fix: Filter field types correctly Signed-off-by: Ashwin Pc <[email protected]> * fix: minor Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Add wizard saved objects to vis list (#1933) via appExtensions of alias registration fixes #1887 Signed-off-by: Josh Romero <[email protected]> * [D&D] Feature/experimental (#1934) * feat: experimental banner Signed-off-by: Ashwin Pc <[email protected]> * feat: experimental embeddable Signed-off-by: Ashwin Pc <[email protected]> * fix: experimental banner location Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Remove search/hasMatch embeddable vestiges (#1935) - removedebugging rendering - also update embeddables icon fixes #1910, #1925 Signed-off-by: Josh Romero <[email protected]> * [D&D] Refactor and cleanup embeddables (#1947) General plugin updates (#1939): - add start service getters/setters to plugin service - move setters from setup to start so they're available to embeddable Embeddable updates: - use getters instead of depending on start services in constructor - remove wizard from add panel "create" list - add correct edit paths/URLs for linking to wizard #1940 - add basic error embeddable rendering - render via ExpressionLoader instead of wizard_component #1920 - wizard_component no longer used, but updated for future use - add subscription handling for query, filter, timerange changes #1937 - fix clone/replace panel actions #1943, #1944 - fix title/description panel rendering #1921 - add inspection panel action #1936 Asset updates: - Update empty workspace illustration - Add secondary fill icon version to match new visualization icons fixes #1936, #1920, #1937, #1940, #1921, #1939, #1941, #1943, #1944 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix index pattern state and loading (#1949) Remove useIndexPattern hook in favor of useIndexPatterns fixes #1917 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix duplicate title warning (#1950) fixes #1918 Signed-off-by: Josh Romero <[email protected]> * [D&D] Adds autosave while editing aggregation (#1953) * fest: Adds autosave while editing agg Signed-off-by: Ashwin Pc <[email protected]> * fix: autosave order Signed-off-by: Ashwin Pc <[email protected]> * fix: spelling Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> * [D&D] Fixes autosave with debounce (#1965) * fix: autosave editing Signed-off-by: Ashwin Pc <[email protected]> * chore: improve workspace animation Signed-off-by: Ashwin Pc <[email protected]> * fix: show invalid field when editing Signed-off-by: Ashwin Pc <[email protected]> * fix: header offset Signed-off-by: Ashwin Pc <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/server/index.ts Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/server/types.ts Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * [D&D] Final fixes (#2071) * chore: Disable wizard by default Signed-off-by: Ashwin Pc <[email protected]> * chore: remove routes Signed-off-by: Ashwin Pc <[email protected]> * chore: remove translations Signed-off-by: Ashwin Pc <[email protected]> * chore: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: adds license to scss files Signed-off-by: Ashwin Pc <[email protected]> * chore: drop hover dark mode Signed-off-by: Ashwin Pc <[email protected]> * chore: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Initial functional tests (#2070) * fix: searchable dropdown Signed-off-by: Ashwin Pc <[email protected]> * fix: broken empty test Signed-off-by: Ashwin Pc <[email protected]> * test(FTR): Adds basic functional tests for D&D Signed-off-by: Ashwin Pc <[email protected]> * test(FTR): Adds CI group 13 to test workflow Signed-off-by: Ashwin Pc <[email protected]> * fix: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: att test to jenkinsfile Signed-off-by: Ashwin Pc <[email protected]> * chore: minor nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: downgrade redux-toolkit for plugin compatibility Signed-off-by: Ashwin Pc <[email protected]> * chore: add docker config flag Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> Co-authored-by: Brooke <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Kartik Desai <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]>
…pensearch-project#1966) Backport PR: opensearch-project#1966 Backport PR commit message: * [Chore] Moves Drag and Drop to new branch (opensearch-project#1400) * Initial Drag and Drop plugin code (opensearch-project#946) * Initial Drag and Drop plugin code Signed-off-by: Ashwin Pc <[email protected]> * Adds state management to Drag and Drop Signed-off-by: Ashwin Pc <[email protected]> * Moves Drag and Drop to create visualization menu Signed-off-by: Ashwin Pc <[email protected]> * Field Search in Data panel (opensearch-project#995) Add ability to search on index fields Signed-off-by: Abbas Hussain <[email protected]> * Adds initial type service (opensearch-project#1260) Signed-off-by: Ashwin Pc <[email protected]> * chore: updates viz modal snapshot Signed-off-by: Ashwin Pc <[email protected]> * fix(License): Fixes license headers Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> * [D&D] Type Service Contributions (opensearch-project#1402) * feat(Contributions): Simple working contributions Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Add new field from dropbox Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Working edit mode Signed-off-by: Ashwin Pc <[email protected]> * fix(Contributions): Fixes switching dropbox fields Signed-off-by: Ashwin Pc <[email protected]> * chore: Updates license headers Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Adds initial drag & drop validation Signed-off-by: Ashwin Pc <[email protected]> * feat(Dropbox): Allows multiple instances of the same field Signed-off-by: Ashwin Pc <[email protected]> * feat(Dropbox): Working reorder fields Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Working container contributions Signed-off-by: Ashwin Pc <[email protected]> * chore: clean up exports Signed-off-by: Ashwin Pc <[email protected]> * test(Contribution): Adds unit test `mergeArrays` Signed-off-by: Ashwin Pc <[email protected]> * test(TypeService): Adds plugin unit tests Signed-off-by: Ashwin Pc <[email protected]> * chore: remove redundant code Signed-off-by: Ashwin Pc <[email protected]> * test(Functional): Updates Chart types Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Refactor to use AggService and introduce metric visualization (opensearch-project#1734) * partial progress Signed-off-by: Ashwin Pc <[email protected]> * simle workign metric using aggShemas Signed-off-by: Ashwin Pc <[email protected]> * updated VisualizationTypeOptions to be a generic Signed-off-by: Ashwin Pc <[email protected]> * partially working metric style options Signed-off-by: Ashwin Pc <[email protected]> * all state objects are serializeable Signed-off-by: Ashwin Pc <[email protected]> * working delete and reorder Signed-off-by: Ashwin Pc <[email protected]> * chore: cleanup agg service changes Signed-off-by: Ashwin Pc <[email protected]> * Adds the data source selector and a useIndexPatterns hook (opensearch-project#1763) Signed-off-by: Brooke Green <[email protected]> * [D&D] Adding and editing an aggregation + metric color ranges (opensearch-project#1781) * edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * cleanup dropbox field icon Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * Updated comment Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Enable basic saved object management (opensearch-project#1816) * [D&D] Enable basic saved object management - Create README stub for saved_objects_management plugin - Register wizard saved object loader with management plugin - Add management methods to SavedObjectsType - Add capabilities provider to wizard - Add saved wizard vis SavedObjectClass and SavedObjectLoader - Add public plugin start method partially addresses opensearch-project#1620 Signed-off-by: Josh Romero <[email protected]> * [Doc] Add clarifications to README for save objects management plugin Signed-off-by: Josh Romero <[email protected]> * [D&D] Adds drop validation (opensearch-project#1833) * edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]> * chore: updates D&D icon (opensearch-project#1844) Signed-off-by: Ashwin Pc <[email protected]> * Chore/remove contributions (opensearch-project#1843) * adds min/max validation Signed-off-by: Ashwin Pc <[email protected]> * relocated contributions Signed-off-by: Ashwin Pc <[email protected]> * Some more cleanup Signed-off-by: Ashwin Pc <[email protected]> * minor fixes Signed-off-by: Ashwin Pc <[email protected]> * one more unnecessary file Signed-off-by: Ashwin Pc <[email protected]> * fix: Seconday panel title Signed-off-by: Ashwin Pc <[email protected]> * chore: Updates Field selector (opensearch-project#1845) Signed-off-by: Ashwin Pc <[email protected]> * Adding breadcrumbs for drag and drop creation (opensearch-project#1797) Signed-off-by: Brooke Green <[email protected]> * fix(D&D): fixes reloading app (opensearch-project#1855) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Dropbox style and animations (opensearch-project#1863) * fix dropbox styles and added animations Signed-off-by: Ashwin Pc <[email protected]> * simpler usePrefersReducedMotion Signed-off-by: Ashwin Pc <[email protected]> * fix drop target animation Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Basic saving, loading, and updating (opensearch-project#1870) * [D&D] Enable basic saving and loading - Add `/edit` route - Sync state for saving and loading - Add setter for vizualization slice - Switch from BrowserRouter to Router - Add version to saved objects - Add savedWizardLoader to services - store visualization and style states separately - add version - update breadcrumb handling - move useSavedWizardVis to top_nav - handle savedObjectNotFound - use savedObjectLoader correctly - allow copy on save - update url and chrome on save - add type for WizardVisSavedObject fixes opensearch-project#1867 Signed-off-by: Josh Romero <[email protected]> * chore: Adds a few readme's (opensearch-project#1894) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Empty-workspace polish (opensearch-project#1900) * empty workspace polish Signed-off-by: kaddy645 <[email protected]> * pr update Signed-off-by: kaddy645 <[email protected]> * pr update 2 Signed-off-by: kaddy645 <[email protected]> * [D&D] Fix: Topnav updates aggregation parameters (opensearch-project#1905) * fix(D&D): Fixes top nav query and timerange Signed-off-by: Ashwin Pc <[email protected]> * fix(D&D): Handles topnav state update Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Add a flag in the YAML config to enable and disable the D&D plugin (opensearch-project#1889) Resolves Issue - opensearch-project#1877 Signed-off-by: Manasvini B Suryanarayana <[email protected]> * fix(Workspace): Fixes illustration and copy (opensearch-project#1916) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Misc fixes (opensearch-project#1924) * fix: minor fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: nit syntax fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: simplify useSavedWizardVis Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Enable basic embeddable panels (opensearch-project#1911) - add embeddable, embeddable component, embeddable factory - update `toExpression` to allow passing services - register embeddable factory in plugin setup fixes opensearch-project#1908 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix scss lint and available fields (opensearch-project#1927) * fix(Lint): fixes scss linting issues Signed-off-by: Ashwin Pc <[email protected]> * fix: Filter field types correctly Signed-off-by: Ashwin Pc <[email protected]> * fix: minor Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Add wizard saved objects to vis list (opensearch-project#1933) via appExtensions of alias registration fixes opensearch-project#1887 Signed-off-by: Josh Romero <[email protected]> * [D&D] Feature/experimental (opensearch-project#1934) * feat: experimental banner Signed-off-by: Ashwin Pc <[email protected]> * feat: experimental embeddable Signed-off-by: Ashwin Pc <[email protected]> * fix: experimental banner location Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Remove search/hasMatch embeddable vestiges (opensearch-project#1935) - removedebugging rendering - also update embeddables icon fixes opensearch-project#1910, opensearch-project#1925 Signed-off-by: Josh Romero <[email protected]> * [D&D] Refactor and cleanup embeddables (opensearch-project#1947) General plugin updates (opensearch-project#1939): - add start service getters/setters to plugin service - move setters from setup to start so they're available to embeddable Embeddable updates: - use getters instead of depending on start services in constructor - remove wizard from add panel "create" list - add correct edit paths/URLs for linking to wizard opensearch-project#1940 - add basic error embeddable rendering - render via ExpressionLoader instead of wizard_component opensearch-project#1920 - wizard_component no longer used, but updated for future use - add subscription handling for query, filter, timerange changes opensearch-project#1937 - fix clone/replace panel actions opensearch-project#1943, opensearch-project#1944 - fix title/description panel rendering opensearch-project#1921 - add inspection panel action opensearch-project#1936 Asset updates: - Update empty workspace illustration - Add secondary fill icon version to match new visualization icons fixes opensearch-project#1936, opensearch-project#1920, opensearch-project#1937, opensearch-project#1940, opensearch-project#1921, opensearch-project#1939, opensearch-project#1941, opensearch-project#1943, opensearch-project#1944 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix index pattern state and loading (opensearch-project#1949) Remove useIndexPattern hook in favor of useIndexPatterns fixes opensearch-project#1917 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix duplicate title warning (opensearch-project#1950) fixes opensearch-project#1918 Signed-off-by: Josh Romero <[email protected]> * [D&D] Adds autosave while editing aggregation (opensearch-project#1953) * fest: Adds autosave while editing agg Signed-off-by: Ashwin Pc <[email protected]> * fix: autosave order Signed-off-by: Ashwin Pc <[email protected]> * fix: spelling Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> * [D&D] Fixes autosave with debounce (opensearch-project#1965) * fix: autosave editing Signed-off-by: Ashwin Pc <[email protected]> * chore: improve workspace animation Signed-off-by: Ashwin Pc <[email protected]> * fix: show invalid field when editing Signed-off-by: Ashwin Pc <[email protected]> * fix: header offset Signed-off-by: Ashwin Pc <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/server/index.ts Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/server/types.ts Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * [D&D] Final fixes (opensearch-project#2071) * chore: Disable wizard by default Signed-off-by: Ashwin Pc <[email protected]> * chore: remove routes Signed-off-by: Ashwin Pc <[email protected]> * chore: remove translations Signed-off-by: Ashwin Pc <[email protected]> * chore: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: adds license to scss files Signed-off-by: Ashwin Pc <[email protected]> * chore: drop hover dark mode Signed-off-by: Ashwin Pc <[email protected]> * chore: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Initial functional tests (opensearch-project#2070) * fix: searchable dropdown Signed-off-by: Ashwin Pc <[email protected]> * fix: broken empty test Signed-off-by: Ashwin Pc <[email protected]> * test(FTR): Adds basic functional tests for D&D Signed-off-by: Ashwin Pc <[email protected]> * test(FTR): Adds CI group 13 to test workflow Signed-off-by: Ashwin Pc <[email protected]> * fix: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: att test to jenkinsfile Signed-off-by: Ashwin Pc <[email protected]> * chore: minor nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: downgrade redux-toolkit for plugin compatibility Signed-off-by: Ashwin Pc <[email protected]> * chore: add docker config flag Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> Co-authored-by: Brooke <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Kartik Desai <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]>
Backport PR: opensearch-project#1966 Backport PR commit message: * [Chore] Moves Drag and Drop to new branch (opensearch-project#1400) * Initial Drag and Drop plugin code (opensearch-project#946) * Initial Drag and Drop plugin code Signed-off-by: Ashwin Pc <[email protected]> * Adds state management to Drag and Drop Signed-off-by: Ashwin Pc <[email protected]> * Moves Drag and Drop to create visualization menu Signed-off-by: Ashwin Pc <[email protected]> * Field Search in Data panel (opensearch-project#995) Add ability to search on index fields Signed-off-by: Abbas Hussain <[email protected]> * Adds initial type service (opensearch-project#1260) Signed-off-by: Ashwin Pc <[email protected]> * chore: updates viz modal snapshot Signed-off-by: Ashwin Pc <[email protected]> * fix(License): Fixes license headers Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> * [D&D] Type Service Contributions (opensearch-project#1402) * feat(Contributions): Simple working contributions Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Add new field from dropbox Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Working edit mode Signed-off-by: Ashwin Pc <[email protected]> * fix(Contributions): Fixes switching dropbox fields Signed-off-by: Ashwin Pc <[email protected]> * chore: Updates license headers Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Adds initial drag & drop validation Signed-off-by: Ashwin Pc <[email protected]> * feat(Dropbox): Allows multiple instances of the same field Signed-off-by: Ashwin Pc <[email protected]> * feat(Dropbox): Working reorder fields Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Working container contributions Signed-off-by: Ashwin Pc <[email protected]> * chore: clean up exports Signed-off-by: Ashwin Pc <[email protected]> * test(Contribution): Adds unit test `mergeArrays` Signed-off-by: Ashwin Pc <[email protected]> * test(TypeService): Adds plugin unit tests Signed-off-by: Ashwin Pc <[email protected]> * chore: remove redundant code Signed-off-by: Ashwin Pc <[email protected]> * test(Functional): Updates Chart types Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Refactor to use AggService and introduce metric visualization (opensearch-project#1734) * partial progress Signed-off-by: Ashwin Pc <[email protected]> * simle workign metric using aggShemas Signed-off-by: Ashwin Pc <[email protected]> * updated VisualizationTypeOptions to be a generic Signed-off-by: Ashwin Pc <[email protected]> * partially working metric style options Signed-off-by: Ashwin Pc <[email protected]> * all state objects are serializeable Signed-off-by: Ashwin Pc <[email protected]> * working delete and reorder Signed-off-by: Ashwin Pc <[email protected]> * chore: cleanup agg service changes Signed-off-by: Ashwin Pc <[email protected]> * Adds the data source selector and a useIndexPatterns hook (opensearch-project#1763) Signed-off-by: Brooke Green <[email protected]> * [D&D] Adding and editing an aggregation + metric color ranges (opensearch-project#1781) * edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * cleanup dropbox field icon Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * Updated comment Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Enable basic saved object management (opensearch-project#1816) * [D&D] Enable basic saved object management - Create README stub for saved_objects_management plugin - Register wizard saved object loader with management plugin - Add management methods to SavedObjectsType - Add capabilities provider to wizard - Add saved wizard vis SavedObjectClass and SavedObjectLoader - Add public plugin start method partially addresses opensearch-project#1620 Signed-off-by: Josh Romero <[email protected]> * [Doc] Add clarifications to README for save objects management plugin Signed-off-by: Josh Romero <[email protected]> * [D&D] Adds drop validation (opensearch-project#1833) * edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]> * chore: updates D&D icon (opensearch-project#1844) Signed-off-by: Ashwin Pc <[email protected]> * Chore/remove contributions (opensearch-project#1843) * adds min/max validation Signed-off-by: Ashwin Pc <[email protected]> * relocated contributions Signed-off-by: Ashwin Pc <[email protected]> * Some more cleanup Signed-off-by: Ashwin Pc <[email protected]> * minor fixes Signed-off-by: Ashwin Pc <[email protected]> * one more unnecessary file Signed-off-by: Ashwin Pc <[email protected]> * fix: Seconday panel title Signed-off-by: Ashwin Pc <[email protected]> * chore: Updates Field selector (opensearch-project#1845) Signed-off-by: Ashwin Pc <[email protected]> * Adding breadcrumbs for drag and drop creation (opensearch-project#1797) Signed-off-by: Brooke Green <[email protected]> * fix(D&D): fixes reloading app (opensearch-project#1855) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Dropbox style and animations (opensearch-project#1863) * fix dropbox styles and added animations Signed-off-by: Ashwin Pc <[email protected]> * simpler usePrefersReducedMotion Signed-off-by: Ashwin Pc <[email protected]> * fix drop target animation Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Basic saving, loading, and updating (opensearch-project#1870) * [D&D] Enable basic saving and loading - Add `/edit` route - Sync state for saving and loading - Add setter for vizualization slice - Switch from BrowserRouter to Router - Add version to saved objects - Add savedWizardLoader to services - store visualization and style states separately - add version - update breadcrumb handling - move useSavedWizardVis to top_nav - handle savedObjectNotFound - use savedObjectLoader correctly - allow copy on save - update url and chrome on save - add type for WizardVisSavedObject fixes opensearch-project#1867 Signed-off-by: Josh Romero <[email protected]> * chore: Adds a few readme's (opensearch-project#1894) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Empty-workspace polish (opensearch-project#1900) * empty workspace polish Signed-off-by: kaddy645 <[email protected]> * pr update Signed-off-by: kaddy645 <[email protected]> * pr update 2 Signed-off-by: kaddy645 <[email protected]> * [D&D] Fix: Topnav updates aggregation parameters (opensearch-project#1905) * fix(D&D): Fixes top nav query and timerange Signed-off-by: Ashwin Pc <[email protected]> * fix(D&D): Handles topnav state update Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Add a flag in the YAML config to enable and disable the D&D plugin (opensearch-project#1889) Resolves Issue - opensearch-project#1877 Signed-off-by: Manasvini B Suryanarayana <[email protected]> * fix(Workspace): Fixes illustration and copy (opensearch-project#1916) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Misc fixes (opensearch-project#1924) * fix: minor fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: nit syntax fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: simplify useSavedWizardVis Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Enable basic embeddable panels (opensearch-project#1911) - add embeddable, embeddable component, embeddable factory - update `toExpression` to allow passing services - register embeddable factory in plugin setup fixes opensearch-project#1908 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix scss lint and available fields (opensearch-project#1927) * fix(Lint): fixes scss linting issues Signed-off-by: Ashwin Pc <[email protected]> * fix: Filter field types correctly Signed-off-by: Ashwin Pc <[email protected]> * fix: minor Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Add wizard saved objects to vis list (opensearch-project#1933) via appExtensions of alias registration fixes opensearch-project#1887 Signed-off-by: Josh Romero <[email protected]> * [D&D] Feature/experimental (opensearch-project#1934) * feat: experimental banner Signed-off-by: Ashwin Pc <[email protected]> * feat: experimental embeddable Signed-off-by: Ashwin Pc <[email protected]> * fix: experimental banner location Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Remove search/hasMatch embeddable vestiges (opensearch-project#1935) - removedebugging rendering - also update embeddables icon fixes opensearch-project#1910, opensearch-project#1925 Signed-off-by: Josh Romero <[email protected]> * [D&D] Refactor and cleanup embeddables (opensearch-project#1947) General plugin updates (opensearch-project#1939): - add start service getters/setters to plugin service - move setters from setup to start so they're available to embeddable Embeddable updates: - use getters instead of depending on start services in constructor - remove wizard from add panel "create" list - add correct edit paths/URLs for linking to wizard opensearch-project#1940 - add basic error embeddable rendering - render via ExpressionLoader instead of wizard_component opensearch-project#1920 - wizard_component no longer used, but updated for future use - add subscription handling for query, filter, timerange changes opensearch-project#1937 - fix clone/replace panel actions opensearch-project#1943, opensearch-project#1944 - fix title/description panel rendering opensearch-project#1921 - add inspection panel action opensearch-project#1936 Asset updates: - Update empty workspace illustration - Add secondary fill icon version to match new visualization icons fixes opensearch-project#1936, opensearch-project#1920, opensearch-project#1937, opensearch-project#1940, opensearch-project#1921, opensearch-project#1939, opensearch-project#1941, opensearch-project#1943, opensearch-project#1944 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix index pattern state and loading (opensearch-project#1949) Remove useIndexPattern hook in favor of useIndexPatterns fixes opensearch-project#1917 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix duplicate title warning (opensearch-project#1950) fixes opensearch-project#1918 Signed-off-by: Josh Romero <[email protected]> * [D&D] Adds autosave while editing aggregation (opensearch-project#1953) * fest: Adds autosave while editing agg Signed-off-by: Ashwin Pc <[email protected]> * fix: autosave order Signed-off-by: Ashwin Pc <[email protected]> * fix: spelling Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> * [D&D] Fixes autosave with debounce (opensearch-project#1965) * fix: autosave editing Signed-off-by: Ashwin Pc <[email protected]> * chore: improve workspace animation Signed-off-by: Ashwin Pc <[email protected]> * fix: show invalid field when editing Signed-off-by: Ashwin Pc <[email protected]> * fix: header offset Signed-off-by: Ashwin Pc <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/server/index.ts Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/server/types.ts Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * [D&D] Final fixes (opensearch-project#2071) * chore: Disable wizard by default Signed-off-by: Ashwin Pc <[email protected]> * chore: remove routes Signed-off-by: Ashwin Pc <[email protected]> * chore: remove translations Signed-off-by: Ashwin Pc <[email protected]> * chore: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: adds license to scss files Signed-off-by: Ashwin Pc <[email protected]> * chore: drop hover dark mode Signed-off-by: Ashwin Pc <[email protected]> * chore: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Initial functional tests (opensearch-project#2070) * fix: searchable dropdown Signed-off-by: Ashwin Pc <[email protected]> * fix: broken empty test Signed-off-by: Ashwin Pc <[email protected]> * test(FTR): Adds basic functional tests for D&D Signed-off-by: Ashwin Pc <[email protected]> * test(FTR): Adds CI group 13 to test workflow Signed-off-by: Ashwin Pc <[email protected]> * fix: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: att test to jenkinsfile Signed-off-by: Ashwin Pc <[email protected]> * chore: minor nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: downgrade redux-toolkit for plugin compatibility Signed-off-by: Ashwin Pc <[email protected]> * chore: add docker config flag Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> Co-authored-by: Brooke <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Kartik Desai <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]>
Backport PR: opensearch-project#1966 Signed-off-by: Anan Zhuang <[email protected]> Backport PR commit message: * [Chore] Moves Drag and Drop to new branch (opensearch-project#1400) * Initial Drag and Drop plugin code (opensearch-project#946) * Initial Drag and Drop plugin code Signed-off-by: Ashwin Pc <[email protected]> * Adds state management to Drag and Drop Signed-off-by: Ashwin Pc <[email protected]> * Moves Drag and Drop to create visualization menu Signed-off-by: Ashwin Pc <[email protected]> * Field Search in Data panel (opensearch-project#995) Add ability to search on index fields Signed-off-by: Abbas Hussain <[email protected]> * Adds initial type service (opensearch-project#1260) Signed-off-by: Ashwin Pc <[email protected]> * chore: updates viz modal snapshot Signed-off-by: Ashwin Pc <[email protected]> * fix(License): Fixes license headers Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> * [D&D] Type Service Contributions (opensearch-project#1402) * feat(Contributions): Simple working contributions Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Add new field from dropbox Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Working edit mode Signed-off-by: Ashwin Pc <[email protected]> * fix(Contributions): Fixes switching dropbox fields Signed-off-by: Ashwin Pc <[email protected]> * chore: Updates license headers Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Adds initial drag & drop validation Signed-off-by: Ashwin Pc <[email protected]> * feat(Dropbox): Allows multiple instances of the same field Signed-off-by: Ashwin Pc <[email protected]> * feat(Dropbox): Working reorder fields Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Working container contributions Signed-off-by: Ashwin Pc <[email protected]> * chore: clean up exports Signed-off-by: Ashwin Pc <[email protected]> * test(Contribution): Adds unit test `mergeArrays` Signed-off-by: Ashwin Pc <[email protected]> * test(TypeService): Adds plugin unit tests Signed-off-by: Ashwin Pc <[email protected]> * chore: remove redundant code Signed-off-by: Ashwin Pc <[email protected]> * test(Functional): Updates Chart types Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Refactor to use AggService and introduce metric visualization (opensearch-project#1734) * partial progress Signed-off-by: Ashwin Pc <[email protected]> * simle workign metric using aggShemas Signed-off-by: Ashwin Pc <[email protected]> * updated VisualizationTypeOptions to be a generic Signed-off-by: Ashwin Pc <[email protected]> * partially working metric style options Signed-off-by: Ashwin Pc <[email protected]> * all state objects are serializeable Signed-off-by: Ashwin Pc <[email protected]> * working delete and reorder Signed-off-by: Ashwin Pc <[email protected]> * chore: cleanup agg service changes Signed-off-by: Ashwin Pc <[email protected]> * Adds the data source selector and a useIndexPatterns hook (opensearch-project#1763) Signed-off-by: Brooke Green <[email protected]> * [D&D] Adding and editing an aggregation + metric color ranges (opensearch-project#1781) * edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * cleanup dropbox field icon Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * Updated comment Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Enable basic saved object management (opensearch-project#1816) * [D&D] Enable basic saved object management - Create README stub for saved_objects_management plugin - Register wizard saved object loader with management plugin - Add management methods to SavedObjectsType - Add capabilities provider to wizard - Add saved wizard vis SavedObjectClass and SavedObjectLoader - Add public plugin start method partially addresses opensearch-project#1620 Signed-off-by: Josh Romero <[email protected]> * [Doc] Add clarifications to README for save objects management plugin Signed-off-by: Josh Romero <[email protected]> * [D&D] Adds drop validation (opensearch-project#1833) * edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]> * chore: updates D&D icon (opensearch-project#1844) Signed-off-by: Ashwin Pc <[email protected]> * Chore/remove contributions (opensearch-project#1843) * adds min/max validation Signed-off-by: Ashwin Pc <[email protected]> * relocated contributions Signed-off-by: Ashwin Pc <[email protected]> * Some more cleanup Signed-off-by: Ashwin Pc <[email protected]> * minor fixes Signed-off-by: Ashwin Pc <[email protected]> * one more unnecessary file Signed-off-by: Ashwin Pc <[email protected]> * fix: Seconday panel title Signed-off-by: Ashwin Pc <[email protected]> * chore: Updates Field selector (opensearch-project#1845) Signed-off-by: Ashwin Pc <[email protected]> * Adding breadcrumbs for drag and drop creation (opensearch-project#1797) Signed-off-by: Brooke Green <[email protected]> * fix(D&D): fixes reloading app (opensearch-project#1855) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Dropbox style and animations (opensearch-project#1863) * fix dropbox styles and added animations Signed-off-by: Ashwin Pc <[email protected]> * simpler usePrefersReducedMotion Signed-off-by: Ashwin Pc <[email protected]> * fix drop target animation Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Basic saving, loading, and updating (opensearch-project#1870) * [D&D] Enable basic saving and loading - Add `/edit` route - Sync state for saving and loading - Add setter for vizualization slice - Switch from BrowserRouter to Router - Add version to saved objects - Add savedWizardLoader to services - store visualization and style states separately - add version - update breadcrumb handling - move useSavedWizardVis to top_nav - handle savedObjectNotFound - use savedObjectLoader correctly - allow copy on save - update url and chrome on save - add type for WizardVisSavedObject fixes opensearch-project#1867 Signed-off-by: Josh Romero <[email protected]> * chore: Adds a few readme's (opensearch-project#1894) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Empty-workspace polish (opensearch-project#1900) * empty workspace polish Signed-off-by: kaddy645 <[email protected]> * pr update Signed-off-by: kaddy645 <[email protected]> * pr update 2 Signed-off-by: kaddy645 <[email protected]> * [D&D] Fix: Topnav updates aggregation parameters (opensearch-project#1905) * fix(D&D): Fixes top nav query and timerange Signed-off-by: Ashwin Pc <[email protected]> * fix(D&D): Handles topnav state update Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Add a flag in the YAML config to enable and disable the D&D plugin (opensearch-project#1889) Resolves Issue - opensearch-project#1877 Signed-off-by: Manasvini B Suryanarayana <[email protected]> * fix(Workspace): Fixes illustration and copy (opensearch-project#1916) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Misc fixes (opensearch-project#1924) * fix: minor fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: nit syntax fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: simplify useSavedWizardVis Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Enable basic embeddable panels (opensearch-project#1911) - add embeddable, embeddable component, embeddable factory - update `toExpression` to allow passing services - register embeddable factory in plugin setup fixes opensearch-project#1908 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix scss lint and available fields (opensearch-project#1927) * fix(Lint): fixes scss linting issues Signed-off-by: Ashwin Pc <[email protected]> * fix: Filter field types correctly Signed-off-by: Ashwin Pc <[email protected]> * fix: minor Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Add wizard saved objects to vis list (opensearch-project#1933) via appExtensions of alias registration fixes opensearch-project#1887 Signed-off-by: Josh Romero <[email protected]> * [D&D] Feature/experimental (opensearch-project#1934) * feat: experimental banner Signed-off-by: Ashwin Pc <[email protected]> * feat: experimental embeddable Signed-off-by: Ashwin Pc <[email protected]> * fix: experimental banner location Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Remove search/hasMatch embeddable vestiges (opensearch-project#1935) - removedebugging rendering - also update embeddables icon fixes opensearch-project#1910, opensearch-project#1925 Signed-off-by: Josh Romero <[email protected]> * [D&D] Refactor and cleanup embeddables (opensearch-project#1947) General plugin updates (opensearch-project#1939): - add start service getters/setters to plugin service - move setters from setup to start so they're available to embeddable Embeddable updates: - use getters instead of depending on start services in constructor - remove wizard from add panel "create" list - add correct edit paths/URLs for linking to wizard opensearch-project#1940 - add basic error embeddable rendering - render via ExpressionLoader instead of wizard_component opensearch-project#1920 - wizard_component no longer used, but updated for future use - add subscription handling for query, filter, timerange changes opensearch-project#1937 - fix clone/replace panel actions opensearch-project#1943, opensearch-project#1944 - fix title/description panel rendering opensearch-project#1921 - add inspection panel action opensearch-project#1936 Asset updates: - Update empty workspace illustration - Add secondary fill icon version to match new visualization icons fixes opensearch-project#1936, opensearch-project#1920, opensearch-project#1937, opensearch-project#1940, opensearch-project#1921, opensearch-project#1939, opensearch-project#1941, opensearch-project#1943, opensearch-project#1944 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix index pattern state and loading (opensearch-project#1949) Remove useIndexPattern hook in favor of useIndexPatterns fixes opensearch-project#1917 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix duplicate title warning (opensearch-project#1950) fixes opensearch-project#1918 Signed-off-by: Josh Romero <[email protected]> * [D&D] Adds autosave while editing aggregation (opensearch-project#1953) * fest: Adds autosave while editing agg Signed-off-by: Ashwin Pc <[email protected]> * fix: autosave order Signed-off-by: Ashwin Pc <[email protected]> * fix: spelling Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> * [D&D] Fixes autosave with debounce (opensearch-project#1965) * fix: autosave editing Signed-off-by: Ashwin Pc <[email protected]> * chore: improve workspace animation Signed-off-by: Ashwin Pc <[email protected]> * fix: show invalid field when editing Signed-off-by: Ashwin Pc <[email protected]> * fix: header offset Signed-off-by: Ashwin Pc <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/server/index.ts Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/server/types.ts Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * [D&D] Final fixes (opensearch-project#2071) * chore: Disable wizard by default Signed-off-by: Ashwin Pc <[email protected]> * chore: remove routes Signed-off-by: Ashwin Pc <[email protected]> * chore: remove translations Signed-off-by: Ashwin Pc <[email protected]> * chore: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: adds license to scss files Signed-off-by: Ashwin Pc <[email protected]> * chore: drop hover dark mode Signed-off-by: Ashwin Pc <[email protected]> * chore: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Initial functional tests (opensearch-project#2070) * fix: searchable dropdown Signed-off-by: Ashwin Pc <[email protected]> * fix: broken empty test Signed-off-by: Ashwin Pc <[email protected]> * test(FTR): Adds basic functional tests for D&D Signed-off-by: Ashwin Pc <[email protected]> * test(FTR): Adds CI group 13 to test workflow Signed-off-by: Ashwin Pc <[email protected]> * fix: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: att test to jenkinsfile Signed-off-by: Ashwin Pc <[email protected]> * chore: minor nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: downgrade redux-toolkit for plugin compatibility Signed-off-by: Ashwin Pc <[email protected]> * chore: add docker config flag Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> Co-authored-by: Brooke <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Kartik Desai <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]>
…2078) Backport PR: #1966 Signed-off-by: Anan Zhuang <[email protected]> Backport PR commit message: * [Chore] Moves Drag and Drop to new branch (#1400) * Initial Drag and Drop plugin code (#946) * Initial Drag and Drop plugin code Signed-off-by: Ashwin Pc <[email protected]> * Adds state management to Drag and Drop Signed-off-by: Ashwin Pc <[email protected]> * Moves Drag and Drop to create visualization menu Signed-off-by: Ashwin Pc <[email protected]> * Field Search in Data panel (#995) Add ability to search on index fields Signed-off-by: Abbas Hussain <[email protected]> * Adds initial type service (#1260) Signed-off-by: Ashwin Pc <[email protected]> * chore: updates viz modal snapshot Signed-off-by: Ashwin Pc <[email protected]> * fix(License): Fixes license headers Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> * [D&D] Type Service Contributions (#1402) * feat(Contributions): Simple working contributions Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Add new field from dropbox Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Working edit mode Signed-off-by: Ashwin Pc <[email protected]> * fix(Contributions): Fixes switching dropbox fields Signed-off-by: Ashwin Pc <[email protected]> * chore: Updates license headers Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Adds initial drag & drop validation Signed-off-by: Ashwin Pc <[email protected]> * feat(Dropbox): Allows multiple instances of the same field Signed-off-by: Ashwin Pc <[email protected]> * feat(Dropbox): Working reorder fields Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Working container contributions Signed-off-by: Ashwin Pc <[email protected]> * chore: clean up exports Signed-off-by: Ashwin Pc <[email protected]> * test(Contribution): Adds unit test `mergeArrays` Signed-off-by: Ashwin Pc <[email protected]> * test(TypeService): Adds plugin unit tests Signed-off-by: Ashwin Pc <[email protected]> * chore: remove redundant code Signed-off-by: Ashwin Pc <[email protected]> * test(Functional): Updates Chart types Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Refactor to use AggService and introduce metric visualization (#1734) * partial progress Signed-off-by: Ashwin Pc <[email protected]> * simle workign metric using aggShemas Signed-off-by: Ashwin Pc <[email protected]> * updated VisualizationTypeOptions to be a generic Signed-off-by: Ashwin Pc <[email protected]> * partially working metric style options Signed-off-by: Ashwin Pc <[email protected]> * all state objects are serializeable Signed-off-by: Ashwin Pc <[email protected]> * working delete and reorder Signed-off-by: Ashwin Pc <[email protected]> * chore: cleanup agg service changes Signed-off-by: Ashwin Pc <[email protected]> * Adds the data source selector and a useIndexPatterns hook (#1763) Signed-off-by: Brooke Green <[email protected]> * [D&D] Adding and editing an aggregation + metric color ranges (#1781) * edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * cleanup dropbox field icon Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * Updated comment Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Enable basic saved object management (#1816) * [D&D] Enable basic saved object management - Create README stub for saved_objects_management plugin - Register wizard saved object loader with management plugin - Add management methods to SavedObjectsType - Add capabilities provider to wizard - Add saved wizard vis SavedObjectClass and SavedObjectLoader - Add public plugin start method partially addresses #1620 Signed-off-by: Josh Romero <[email protected]> * [Doc] Add clarifications to README for save objects management plugin Signed-off-by: Josh Romero <[email protected]> * [D&D] Adds drop validation (#1833) * edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]> * chore: updates D&D icon (#1844) Signed-off-by: Ashwin Pc <[email protected]> * Chore/remove contributions (#1843) * adds min/max validation Signed-off-by: Ashwin Pc <[email protected]> * relocated contributions Signed-off-by: Ashwin Pc <[email protected]> * Some more cleanup Signed-off-by: Ashwin Pc <[email protected]> * minor fixes Signed-off-by: Ashwin Pc <[email protected]> * one more unnecessary file Signed-off-by: Ashwin Pc <[email protected]> * fix: Seconday panel title Signed-off-by: Ashwin Pc <[email protected]> * chore: Updates Field selector (#1845) Signed-off-by: Ashwin Pc <[email protected]> * Adding breadcrumbs for drag and drop creation (#1797) Signed-off-by: Brooke Green <[email protected]> * fix(D&D): fixes reloading app (#1855) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Dropbox style and animations (#1863) * fix dropbox styles and added animations Signed-off-by: Ashwin Pc <[email protected]> * simpler usePrefersReducedMotion Signed-off-by: Ashwin Pc <[email protected]> * fix drop target animation Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Basic saving, loading, and updating (#1870) * [D&D] Enable basic saving and loading - Add `/edit` route - Sync state for saving and loading - Add setter for vizualization slice - Switch from BrowserRouter to Router - Add version to saved objects - Add savedWizardLoader to services - store visualization and style states separately - add version - update breadcrumb handling - move useSavedWizardVis to top_nav - handle savedObjectNotFound - use savedObjectLoader correctly - allow copy on save - update url and chrome on save - add type for WizardVisSavedObject fixes #1867 Signed-off-by: Josh Romero <[email protected]> * chore: Adds a few readme's (#1894) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Empty-workspace polish (#1900) * empty workspace polish Signed-off-by: kaddy645 <[email protected]> * pr update Signed-off-by: kaddy645 <[email protected]> * pr update 2 Signed-off-by: kaddy645 <[email protected]> * [D&D] Fix: Topnav updates aggregation parameters (#1905) * fix(D&D): Fixes top nav query and timerange Signed-off-by: Ashwin Pc <[email protected]> * fix(D&D): Handles topnav state update Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Add a flag in the YAML config to enable and disable the D&D plugin (#1889) Resolves Issue - #1877 Signed-off-by: Manasvini B Suryanarayana <[email protected]> * fix(Workspace): Fixes illustration and copy (#1916) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Misc fixes (#1924) * fix: minor fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: nit syntax fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: simplify useSavedWizardVis Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Enable basic embeddable panels (#1911) - add embeddable, embeddable component, embeddable factory - update `toExpression` to allow passing services - register embeddable factory in plugin setup fixes #1908 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix scss lint and available fields (#1927) * fix(Lint): fixes scss linting issues Signed-off-by: Ashwin Pc <[email protected]> * fix: Filter field types correctly Signed-off-by: Ashwin Pc <[email protected]> * fix: minor Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Add wizard saved objects to vis list (#1933) via appExtensions of alias registration fixes #1887 Signed-off-by: Josh Romero <[email protected]> * [D&D] Feature/experimental (#1934) * feat: experimental banner Signed-off-by: Ashwin Pc <[email protected]> * feat: experimental embeddable Signed-off-by: Ashwin Pc <[email protected]> * fix: experimental banner location Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Remove search/hasMatch embeddable vestiges (#1935) - removedebugging rendering - also update embeddables icon fixes #1910, #1925 Signed-off-by: Josh Romero <[email protected]> * [D&D] Refactor and cleanup embeddables (#1947) General plugin updates (#1939): - add start service getters/setters to plugin service - move setters from setup to start so they're available to embeddable Embeddable updates: - use getters instead of depending on start services in constructor - remove wizard from add panel "create" list - add correct edit paths/URLs for linking to wizard #1940 - add basic error embeddable rendering - render via ExpressionLoader instead of wizard_component #1920 - wizard_component no longer used, but updated for future use - add subscription handling for query, filter, timerange changes #1937 - fix clone/replace panel actions #1943, #1944 - fix title/description panel rendering #1921 - add inspection panel action #1936 Asset updates: - Update empty workspace illustration - Add secondary fill icon version to match new visualization icons fixes #1936, #1920, #1937, #1940, #1921, #1939, #1941, #1943, #1944 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix index pattern state and loading (#1949) Remove useIndexPattern hook in favor of useIndexPatterns fixes #1917 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix duplicate title warning (#1950) fixes #1918 Signed-off-by: Josh Romero <[email protected]> * [D&D] Adds autosave while editing aggregation (#1953) * fest: Adds autosave while editing agg Signed-off-by: Ashwin Pc <[email protected]> * fix: autosave order Signed-off-by: Ashwin Pc <[email protected]> * fix: spelling Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> * [D&D] Fixes autosave with debounce (#1965) * fix: autosave editing Signed-off-by: Ashwin Pc <[email protected]> * chore: improve workspace animation Signed-off-by: Ashwin Pc <[email protected]> * fix: show invalid field when editing Signed-off-by: Ashwin Pc <[email protected]> * fix: header offset Signed-off-by: Ashwin Pc <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/server/index.ts Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/server/types.ts Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * [D&D] Final fixes (#2071) * chore: Disable wizard by default Signed-off-by: Ashwin Pc <[email protected]> * chore: remove routes Signed-off-by: Ashwin Pc <[email protected]> * chore: remove translations Signed-off-by: Ashwin Pc <[email protected]> * chore: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: adds license to scss files Signed-off-by: Ashwin Pc <[email protected]> * chore: drop hover dark mode Signed-off-by: Ashwin Pc <[email protected]> * chore: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Initial functional tests (#2070) * fix: searchable dropdown Signed-off-by: Ashwin Pc <[email protected]> * fix: broken empty test Signed-off-by: Ashwin Pc <[email protected]> * test(FTR): Adds basic functional tests for D&D Signed-off-by: Ashwin Pc <[email protected]> * test(FTR): Adds CI group 13 to test workflow Signed-off-by: Ashwin Pc <[email protected]> * fix: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: att test to jenkinsfile Signed-off-by: Ashwin Pc <[email protected]> * chore: minor nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: downgrade redux-toolkit for plugin compatibility Signed-off-by: Ashwin Pc <[email protected]> * chore: add docker config flag Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> Co-authored-by: Brooke <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Kartik Desai <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> Co-authored-by: Brooke <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Kartik Desai <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]>
…pensearch-project#2078) Backport PR: opensearch-project#1966 Signed-off-by: Anan Zhuang <[email protected]> Backport PR commit message: * [Chore] Moves Drag and Drop to new branch (opensearch-project#1400) * Initial Drag and Drop plugin code (opensearch-project#946) * Initial Drag and Drop plugin code Signed-off-by: Ashwin Pc <[email protected]> * Adds state management to Drag and Drop Signed-off-by: Ashwin Pc <[email protected]> * Moves Drag and Drop to create visualization menu Signed-off-by: Ashwin Pc <[email protected]> * Field Search in Data panel (opensearch-project#995) Add ability to search on index fields Signed-off-by: Abbas Hussain <[email protected]> * Adds initial type service (opensearch-project#1260) Signed-off-by: Ashwin Pc <[email protected]> * chore: updates viz modal snapshot Signed-off-by: Ashwin Pc <[email protected]> * fix(License): Fixes license headers Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> * [D&D] Type Service Contributions (opensearch-project#1402) * feat(Contributions): Simple working contributions Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Add new field from dropbox Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Working edit mode Signed-off-by: Ashwin Pc <[email protected]> * fix(Contributions): Fixes switching dropbox fields Signed-off-by: Ashwin Pc <[email protected]> * chore: Updates license headers Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Adds initial drag & drop validation Signed-off-by: Ashwin Pc <[email protected]> * feat(Dropbox): Allows multiple instances of the same field Signed-off-by: Ashwin Pc <[email protected]> * feat(Dropbox): Working reorder fields Signed-off-by: Ashwin Pc <[email protected]> * feat(Contributions): Working container contributions Signed-off-by: Ashwin Pc <[email protected]> * chore: clean up exports Signed-off-by: Ashwin Pc <[email protected]> * test(Contribution): Adds unit test `mergeArrays` Signed-off-by: Ashwin Pc <[email protected]> * test(TypeService): Adds plugin unit tests Signed-off-by: Ashwin Pc <[email protected]> * chore: remove redundant code Signed-off-by: Ashwin Pc <[email protected]> * test(Functional): Updates Chart types Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Refactor to use AggService and introduce metric visualization (opensearch-project#1734) * partial progress Signed-off-by: Ashwin Pc <[email protected]> * simle workign metric using aggShemas Signed-off-by: Ashwin Pc <[email protected]> * updated VisualizationTypeOptions to be a generic Signed-off-by: Ashwin Pc <[email protected]> * partially working metric style options Signed-off-by: Ashwin Pc <[email protected]> * all state objects are serializeable Signed-off-by: Ashwin Pc <[email protected]> * working delete and reorder Signed-off-by: Ashwin Pc <[email protected]> * chore: cleanup agg service changes Signed-off-by: Ashwin Pc <[email protected]> * Adds the data source selector and a useIndexPatterns hook (opensearch-project#1763) Signed-off-by: Brooke Green <[email protected]> * [D&D] Adding and editing an aggregation + metric color ranges (opensearch-project#1781) * edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * cleanup dropbox field icon Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * Updated comment Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Enable basic saved object management (opensearch-project#1816) * [D&D] Enable basic saved object management - Create README stub for saved_objects_management plugin - Register wizard saved object loader with management plugin - Add management methods to SavedObjectsType - Add capabilities provider to wizard - Add saved wizard vis SavedObjectClass and SavedObjectLoader - Add public plugin start method partially addresses opensearch-project#1620 Signed-off-by: Josh Romero <[email protected]> * [Doc] Add clarifications to README for save objects management plugin Signed-off-by: Josh Romero <[email protected]> * [D&D] Adds drop validation (opensearch-project#1833) * edit and add agg works Signed-off-by: Ashwin Pc <[email protected]> * edit agg using draft state Signed-off-by: Ashwin Pc <[email protected]> * Adds other metric style props Signed-off-by: Ashwin Pc <[email protected]> * feat: Adds agg type validation and defaults on drop Signed-off-by: Ashwin Pc <[email protected]> * chore: refactor filter Signed-off-by: Ashwin Pc <[email protected]> * chore: updates D&D icon (opensearch-project#1844) Signed-off-by: Ashwin Pc <[email protected]> * Chore/remove contributions (opensearch-project#1843) * adds min/max validation Signed-off-by: Ashwin Pc <[email protected]> * relocated contributions Signed-off-by: Ashwin Pc <[email protected]> * Some more cleanup Signed-off-by: Ashwin Pc <[email protected]> * minor fixes Signed-off-by: Ashwin Pc <[email protected]> * one more unnecessary file Signed-off-by: Ashwin Pc <[email protected]> * fix: Seconday panel title Signed-off-by: Ashwin Pc <[email protected]> * chore: Updates Field selector (opensearch-project#1845) Signed-off-by: Ashwin Pc <[email protected]> * Adding breadcrumbs for drag and drop creation (opensearch-project#1797) Signed-off-by: Brooke Green <[email protected]> * fix(D&D): fixes reloading app (opensearch-project#1855) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Dropbox style and animations (opensearch-project#1863) * fix dropbox styles and added animations Signed-off-by: Ashwin Pc <[email protected]> * simpler usePrefersReducedMotion Signed-off-by: Ashwin Pc <[email protected]> * fix drop target animation Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Basic saving, loading, and updating (opensearch-project#1870) * [D&D] Enable basic saving and loading - Add `/edit` route - Sync state for saving and loading - Add setter for vizualization slice - Switch from BrowserRouter to Router - Add version to saved objects - Add savedWizardLoader to services - store visualization and style states separately - add version - update breadcrumb handling - move useSavedWizardVis to top_nav - handle savedObjectNotFound - use savedObjectLoader correctly - allow copy on save - update url and chrome on save - add type for WizardVisSavedObject fixes opensearch-project#1867 Signed-off-by: Josh Romero <[email protected]> * chore: Adds a few readme's (opensearch-project#1894) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Empty-workspace polish (opensearch-project#1900) * empty workspace polish Signed-off-by: kaddy645 <[email protected]> * pr update Signed-off-by: kaddy645 <[email protected]> * pr update 2 Signed-off-by: kaddy645 <[email protected]> * [D&D] Fix: Topnav updates aggregation parameters (opensearch-project#1905) * fix(D&D): Fixes top nav query and timerange Signed-off-by: Ashwin Pc <[email protected]> * fix(D&D): Handles topnav state update Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Add a flag in the YAML config to enable and disable the D&D plugin (opensearch-project#1889) Resolves Issue - opensearch-project#1877 Signed-off-by: Manasvini B Suryanarayana <[email protected]> * fix(Workspace): Fixes illustration and copy (opensearch-project#1916) Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Misc fixes (opensearch-project#1924) * fix: minor fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: nit syntax fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: simplify useSavedWizardVis Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Enable basic embeddable panels (opensearch-project#1911) - add embeddable, embeddable component, embeddable factory - update `toExpression` to allow passing services - register embeddable factory in plugin setup fixes opensearch-project#1908 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix scss lint and available fields (opensearch-project#1927) * fix(Lint): fixes scss linting issues Signed-off-by: Ashwin Pc <[email protected]> * fix: Filter field types correctly Signed-off-by: Ashwin Pc <[email protected]> * fix: minor Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Add wizard saved objects to vis list (opensearch-project#1933) via appExtensions of alias registration fixes opensearch-project#1887 Signed-off-by: Josh Romero <[email protected]> * [D&D] Feature/experimental (opensearch-project#1934) * feat: experimental banner Signed-off-by: Ashwin Pc <[email protected]> * feat: experimental embeddable Signed-off-by: Ashwin Pc <[email protected]> * fix: experimental banner location Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Remove search/hasMatch embeddable vestiges (opensearch-project#1935) - removedebugging rendering - also update embeddables icon fixes opensearch-project#1910, opensearch-project#1925 Signed-off-by: Josh Romero <[email protected]> * [D&D] Refactor and cleanup embeddables (opensearch-project#1947) General plugin updates (opensearch-project#1939): - add start service getters/setters to plugin service - move setters from setup to start so they're available to embeddable Embeddable updates: - use getters instead of depending on start services in constructor - remove wizard from add panel "create" list - add correct edit paths/URLs for linking to wizard opensearch-project#1940 - add basic error embeddable rendering - render via ExpressionLoader instead of wizard_component opensearch-project#1920 - wizard_component no longer used, but updated for future use - add subscription handling for query, filter, timerange changes opensearch-project#1937 - fix clone/replace panel actions opensearch-project#1943, opensearch-project#1944 - fix title/description panel rendering opensearch-project#1921 - add inspection panel action opensearch-project#1936 Asset updates: - Update empty workspace illustration - Add secondary fill icon version to match new visualization icons fixes opensearch-project#1936, opensearch-project#1920, opensearch-project#1937, opensearch-project#1940, opensearch-project#1921, opensearch-project#1939, opensearch-project#1941, opensearch-project#1943, opensearch-project#1944 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix index pattern state and loading (opensearch-project#1949) Remove useIndexPattern hook in favor of useIndexPatterns fixes opensearch-project#1917 Signed-off-by: Josh Romero <[email protected]> * [D&D] Fix duplicate title warning (opensearch-project#1950) fixes opensearch-project#1918 Signed-off-by: Josh Romero <[email protected]> * [D&D] Adds autosave while editing aggregation (opensearch-project#1953) * fest: Adds autosave while editing agg Signed-off-by: Ashwin Pc <[email protected]> * fix: autosave order Signed-off-by: Ashwin Pc <[email protected]> * fix: spelling Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> * [D&D] Fixes autosave with debounce (opensearch-project#1965) * fix: autosave editing Signed-off-by: Ashwin Pc <[email protected]> * chore: improve workspace animation Signed-off-by: Ashwin Pc <[email protected]> * fix: show invalid field when editing Signed-off-by: Ashwin Pc <[email protected]> * fix: header offset Signed-off-by: Ashwin Pc <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/server/index.ts Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/server/types.ts Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/wizard/README.md Co-authored-by: Josh Romero <[email protected]> * Update src/plugins/saved_objects_management/README.md Co-authored-by: Josh Romero <[email protected]> * [D&D] Final fixes (opensearch-project#2071) * chore: Disable wizard by default Signed-off-by: Ashwin Pc <[email protected]> * chore: remove routes Signed-off-by: Ashwin Pc <[email protected]> * chore: remove translations Signed-off-by: Ashwin Pc <[email protected]> * chore: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: adds license to scss files Signed-off-by: Ashwin Pc <[email protected]> * chore: drop hover dark mode Signed-off-by: Ashwin Pc <[email protected]> * chore: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * [D&D] Initial functional tests (opensearch-project#2070) * fix: searchable dropdown Signed-off-by: Ashwin Pc <[email protected]> * fix: broken empty test Signed-off-by: Ashwin Pc <[email protected]> * test(FTR): Adds basic functional tests for D&D Signed-off-by: Ashwin Pc <[email protected]> * test(FTR): Adds CI group 13 to test workflow Signed-off-by: Ashwin Pc <[email protected]> * fix: nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: att test to jenkinsfile Signed-off-by: Ashwin Pc <[email protected]> * chore: minor nit fixes Signed-off-by: Ashwin Pc <[email protected]> * chore: downgrade redux-toolkit for plugin compatibility Signed-off-by: Ashwin Pc <[email protected]> * chore: add docker config flag Signed-off-by: Ashwin Pc <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> Co-authored-by: Brooke <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Kartik Desai <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> Co-authored-by: Brooke <[email protected]> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Kartik Desai <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]>
Description
This PR adds validation to check if the field being dragged can be dropped in a dropbox and if so which default aggregation should be used.
Issues Resolved
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr